Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Annotations
    • Labels:
      None

      Description

      When parsing a class the DocParser uses class_exists() to check for annotation classes (this triggers autoloading) - only afterwards the annotation is ignored if it should be ignored.

      At least for simple unqualified names the check against the ignored annotations could be done earlier. This already goes a long way:

      ----- DocParser.php, at about line 555 -----
      // only process names which are not fully qualified, yet
      // fully qualified names must start with a \
      $originalName = $name;
      if ('
      ' !== $name[0]) {
      // check early and return before further inspections
      if (isset($this->ignoredAnnotationNames[$name]))

      { return FALSE; }

      $alias = (false === $pos = strpos($name, '
      '))? $name : substr($name, 0, $pos);

      ----- DocParser.php, at about line 555 -----

        Activity

        Karsten Dambekalns created issue -
        Fabio B. Silva made changes -
        Field Original Value New Value
        Assignee Benjamin Eberlei [ beberlei ] Fabio B. Silva [ fabio.bat.silva ]
        Hide
        Fabio B. Silva added a comment -
        Show
        Fabio B. Silva added a comment - Other explanations : https://github.com/doctrine/common/pull/90#issuecomment-3313175
        Fabio B. Silva made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Won't Fix [ 2 ]
        Benjamin Eberlei made changes -
        Workflow jira [ 13246 ] jira-feedback2 [ 17948 ]
        Benjamin Eberlei made changes -
        Workflow jira-feedback2 [ 17948 ] jira-feedback3 [ 19911 ]

        This list may be incomplete, as errors occurred whilst retrieving source from linked applications:

        • Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=DCOM-86, expand=changesets[0:20].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

          People

          • Assignee:
            Fabio B. Silva
            Reporter:
            Karsten Dambekalns
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: