Doctrine Common

Non existant namespace alias throws a PHP Notice

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0.0-BETA2
  • Fix Version/s: 2.0.0-RC1
  • Component/s: None
  • Labels:
    None

Description

@nonalias:Annot results in a php notice.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tim Nagel added a comment -

Proposed tests and fix

http://github.com/merk/common/commit/65e8c10b74201c39dbe291c36230205d9b08ed65

Show
Tim Nagel added a comment - Proposed tests and fix http://github.com/merk/common/commit/65e8c10b74201c39dbe291c36230205d9b08ed65
Hide
Permalink
Guilherme Blanco added a comment -

In commit: http://github.com/doctrine/common/commit/ad49a676269af368563bd9a848c904b81a825622

I fixed this issue.
The validation on unexistent classes cannot be done correctly, otherwise it'd conflict with phpDoc tags.

Show
Guilherme Blanco added a comment - In commit: http://github.com/doctrine/common/commit/ad49a676269af368563bd9a848c904b81a825622 I fixed this issue. The validation on unexistent classes cannot be done correctly, otherwise it'd conflict with phpDoc tags.
Guilherme Blanco made changes -
Field Original Value New Value
Status Open [ 1 ] Closed [ 6 ]
Resolution Fixed [ 1 ]
Hide
Permalink
Tim Nagel added a comment -

What will your change do if there are multiple implementations of the Reader working on entities that dont have common namespaces, but still use namespaces?

Would it not make more sense to skip something that the Reader doesnt understand, rather than throwing an error?

(For example, Symfony2's validator system might have namespaced validators, which would then cause the 'Doctrine' reader to throw an exception)

Show
Tim Nagel added a comment - What will your change do if there are multiple implementations of the Reader working on entities that dont have common namespaces, but still use namespaces? Would it not make more sense to skip something that the Reader doesnt understand, rather than throwing an error? (For example, Symfony2's validator system might have namespaced validators, which would then cause the 'Doctrine' reader to throw an exception)
Hide
Permalink
Guilherme Blanco added a comment -

Yes, you're right...

I think we'll have to silently bypass unknown aliases... this makes debug harder, but we don't have any other option. =(

Reopening it

Show
Guilherme Blanco added a comment - Yes, you're right... I think we'll have to silently bypass unknown aliases... this makes debug harder, but we don't have any other option. =( Reopening it
Guilherme Blanco made changes -
Resolution Fixed [ 1 ]
Status Closed [ 6 ] Reopened [ 4 ]
Hide
Permalink
Benjamin Eberlei added a comment -

Fixed to skip the unknown alias annotation.

Show
Benjamin Eberlei added a comment - Fixed to skip the unknown alias annotation.
Benjamin Eberlei made changes -
Status Reopened [ 4 ] Resolved [ 5 ]
Assignee Roman S. Borschel [ romanb ] Benjamin Eberlei [ beberlei ]
Fix Version/s 2.0.0-RC1 [ 10081 ]
Resolution Fixed [ 1 ]
Benjamin Eberlei made changes -
Workflow jira [ 11419 ] jira-feedback2 [ 17868 ]
Benjamin Eberlei made changes -
Workflow jira-feedback2 [ 17868 ] jira-feedback3 [ 19831 ]
This list may be incomplete, as errors occurred whilst retrieving source from linked applications:
  • Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=DCOM-6, expand=changesets[-21:-1].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

People

  • Assignee:
    Benjamin Eberlei
    Reporter:
    Tim Nagel
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: