Doctrine Common

PhpParser doesn't ignore commented keywords

Details

Description

The PhpParser makes a too optimistic assumption about code convention...

If you have the word 'class' or 'interface' in the comment before the class definition, preg_match_all finds wrong slice of code and PHP complains with a Warning about "Unterminated comment". This occurs only once after the cache is cleared.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Fabio B. Silva added a comment -

Hello all
I tested this issue.

After rewriting the php parser does not happen. : https://github.com/doctrine/common/commit/d274bd7fe9e8f5657c670ed8a22a31024544eeeb

I think that can be closed

Thanks

Show
Fabio B. Silva added a comment - Hello all I tested this issue. After rewriting the php parser does not happen. : https://github.com/doctrine/common/commit/d274bd7fe9e8f5657c670ed8a22a31024544eeeb I think that can be closed Thanks
Hide
Permalink
Michel D'HOOGE added a comment -

Unfortunately, I can't remember when the problem disappeared but it is no longer here for sure.
And since the call to preg_match_all has been removed, we can close the issue.

Show
Michel D'HOOGE added a comment - Unfortunately, I can't remember when the problem disappeared but it is no longer here for sure. And since the call to preg_match_all has been removed, we can close the issue.

People

  • Assignee:
    Benjamin Eberlei
    Reporter:
    Michel D'HOOGE
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: