Doctrine Common
  1. Doctrine Common
  2. DCOM-53

PhpParser doesn't ignore commented keywords

    Details

      Description

      The PhpParser makes a too optimistic assumption about code convention...

      If you have the word 'class' or 'interface' in the comment before the class definition, preg_match_all finds wrong slice of code and PHP complains with a Warning about "Unterminated comment". This occurs only once after the cache is cleared.

        Activity

        Hide
        Fabio B. Silva added a comment -

        Hello all
        I tested this issue.

        After rewriting the php parser does not happen. : https://github.com/doctrine/common/commit/d274bd7fe9e8f5657c670ed8a22a31024544eeeb

        I think that can be closed

        Thanks

        Show
        Fabio B. Silva added a comment - Hello all I tested this issue. After rewriting the php parser does not happen. : https://github.com/doctrine/common/commit/d274bd7fe9e8f5657c670ed8a22a31024544eeeb I think that can be closed Thanks
        Hide
        Michel D'HOOGE added a comment -

        Unfortunately, I can't remember when the problem disappeared but it is no longer here for sure.
        And since the call to preg_match_all has been removed, we can close the issue.

        Show
        Michel D'HOOGE added a comment - Unfortunately, I can't remember when the problem disappeared but it is no longer here for sure. And since the call to preg_match_all has been removed, we can close the issue.

          People

          • Assignee:
            Benjamin Eberlei
            Reporter:
            Michel D'HOOGE
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: