Doctrine Common

When using different class loaders

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Cannot Reproduce
  • Affects Version/s: 2.1
  • Fix Version/s: 2.1.2
  • Component/s: Class Loading
  • Labels:
    None
  • Environment:
    all

Description

ClassLoader::classExists($class); will fail if different class loader is used which does not return any boolean value. This includes Symfony2 UniversalClassLoader

I have never used this function before because native PHP method class_exits($class, true) first will try to autoload. But if the class does not exist
and you are using Doctrine\Common::ClassLoader and you call class_exists($class) it will trigger fatal error. This behavior makes it impossible to make code compatible
with different class loading mechanisms for Doctrine2

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Christophe Coevoet added a comment -

This is known and documented in the code: https://github.com/doctrine/common/blob/master/lib/Doctrine/Common/Annotations/Parser.php#L110

Show
Christophe Coevoet added a comment - This is known and documented in the code: https://github.com/doctrine/common/blob/master/lib/Doctrine/Common/Annotations/Parser.php#L110
Hide
Permalink
Guilherme Blanco added a comment -

Since Annotations package changed a lot since the bug was opened and today, I'm closing the ticket as "Cannot reproduce".

Please reopen it if the issue is still valid with a testcase.

Cheers,

Show
Guilherme Blanco added a comment - Since Annotations package changed a lot since the bug was opened and today, I'm closing the ticket as "Cannot reproduce". Please reopen it if the issue is still valid with a testcase. Cheers,
Hide
Permalink
Benjamin Eberlei added a comment -

This issue is referenced in Github Pull-Request GH-88
https://github.com/doctrine/common/pull/88

Show
Benjamin Eberlei added a comment - This issue is referenced in Github Pull-Request GH-88 https://github.com/doctrine/common/pull/88
Hide
Permalink
Jan Dolecek added a comment -

Still a problem! Especially since this is used by ORM (https://github.com/doctrine/doctrine2/commit/3aea203b9ca77df65f55f036080a9af653194cbf)

Class loader doesn't have to return bool (and usually DOES NOT), so even though it has loaded the class, classExists will return false. Please pull this https://github.com/doctrine/common/pull/88

Show
Jan Dolecek added a comment - Still a problem! Especially since this is used by ORM ( https://github.com/doctrine/doctrine2/commit/3aea203b9ca77df65f55f036080a9af653194cbf ) Class loader doesn't have to return bool (and usually DOES NOT), so even though it has loaded the class, classExists will return false. Please pull this https://github.com/doctrine/common/pull/88
Hide
Permalink
Benjamin Eberlei added a comment -

Related Pull Request was closed: https://github.com/doctrine/common/pull/88

Show
Benjamin Eberlei added a comment - Related Pull Request was closed: https://github.com/doctrine/common/pull/88

People

  • Assignee:
    Guilherme Blanco
    Reporter:
    Gediminas Morkevicius
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: