Doctrine Common
  1. Doctrine Common
  2. DCOM-32

Memcache cache relies on deprecated functions

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-RC2
    • Fix Version/s: 2.2
    • Component/s: Caching
    • Labels:
      None

      Description

      The method getIds() in MemcacheCache relies on the old "cachedump" stat type.

      But as you can read here: http://de2.php.net/manual/en/memcache.getextendedstats.php this has been removed due to security reasons.

        Activity

        Hide
        Przemek Sobstel added a comment -

        @Guilherme, your fix introduced big performance issue as now for each fetch() call there are always 2 additional calls, which is kind of big overhead. See https://github.com/doctrine/common/pull/125 for details.

        Show
        Przemek Sobstel added a comment - @Guilherme, your fix introduced big performance issue as now for each fetch() call there are always 2 additional calls, which is kind of big overhead. See https://github.com/doctrine/common/pull/125 for details.
        Show
        Guilherme Blanco added a comment - Fixed in master by this commit: https://github.com/doctrine/common/commit/486169851ea87b3e14ed45d5bfd7d07b1d41af65
        Show
        Denis added a comment - There additionally seems to be a hard-coded limit to the size of the dump: http://stackoverflow.com/questions/4363904/is-there-any-length-limitation-of-result-by-stats-cachedump-in-memcached http://lists.danga.com/pipermail/memcached/2007-April/003906.html
        Hide
        Guilherme Blanco added a comment -

        Memcache daemon 1.4.5 do not provide cachedump and triggers a couple of issues all around.
        Here is a link that gives more information: http://www.pecl.php.net/bugs/bug.php?id=20375&edit=3

        We need to think on a workaround since current state of Doctrine 2 is unusable with recent memcache.

        Show
        Guilherme Blanco added a comment - Memcache daemon 1.4.5 do not provide cachedump and triggers a couple of issues all around. Here is a link that gives more information: http://www.pecl.php.net/bugs/bug.php?id=20375&edit=3 We need to think on a workaround since current state of Doctrine 2 is unusable with recent memcache.
        Hide
        Guilherme Blanco added a comment -

        This issue doesn't seen to be valid anymore based on commit of @hobodave on Jan 29th.

        Please reopen if it is still valid. I could not reproduce.

        Show
        Guilherme Blanco added a comment - This issue doesn't seen to be valid anymore based on commit of @hobodave on Jan 29th. Please reopen if it is still valid. I could not reproduce.
        Hide
        Sebastian Hoitz added a comment - - edited

        Adding this to memcached before getting the extended stats cachedump fixed this issue for me:

        if(!is_int($slabId)) {
            continue;
        }
        
        Show
        Sebastian Hoitz added a comment - - edited Adding this to memcached before getting the extended stats cachedump fixed this issue for me: if (!is_int($slabId)) { continue ; }

          People

          • Assignee:
            Guilherme Blanco
            Reporter:
            Sebastian Hoitz
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: