Doctrine Common
  1. Doctrine Common
  2. DCOM-223

[GH-308] fix the optimize regex and adapt the tests to actually test classAnnotat...

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5.0
    • Component/s: None
    • Labels:
      None

      Description

      This issue is created automatically through a Github pull request on behalf of dawehner:

      Url: https://github.com/doctrine/common/pull/308

      Message:

      There has been several problems

      • Even we enabled classAnnotationOptimized we expected a different behavior: You cannot parse properties any longer (fixed that by expecting an exception). Therefore moved the test data into a provider so you can check the exception on each of them.
      • Once done I realized that DeeperNamespaceParent had the wrong className
      • Additional I added a test to check that the regex matched.

        Activity

        Hide
        Doctrine Bot added a comment -

        A related Github Pull-Request [GH-308] was closed:
        https://github.com/doctrine/common/pull/308

        Show
        Doctrine Bot added a comment - A related Github Pull-Request [GH-308] was closed: https://github.com/doctrine/common/pull/308
        Show
        Marco Pivetta added a comment - Merged: https://github.com/doctrine/common/commit/a45d110f71c323e29f41eb0696fa230e3fa1b1b5

          People

          • Assignee:
            Guilherme Blanco
            Reporter:
            Doctrine Bot
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: