Add Collection::slice($offset, $length)

Details

Type: Improvement
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: 2.0.0-BETA4
Fix Version/s: 2.0.0-RC1
Component/s: Collections
Labels:
None

Description

Since we are still at a point were bc breaks are potentially not so harming:

We need a slice() method on the Collection for forward compatibility, the support for large and very large collections using FETCH_EXTRA would heavily benefit from a method like this.

/**
 * Extract a slice of $length elements starting at position $offset from the Collection.
 * 
 * If $length is null it returns all elements from $offset to the end of the Collection.
 * Keys have to be preserved by this method.
 * 
 * @param int $offset
 * @param int $length
 * @return array
 */
public function slice($offset, $length = null);

The ArrayCollection implement would be:

public function slice($offset, $length = null);
{
    return array_slice($this->_elements, $offset, $length, true); // preserve keys
}

Activity

Ascending order - Click to sort in descending order

Benjamin Eberlei made changes - 08/Aug/10 11:32 AM

Field	Original Value	New Value
Description	Since we are still at a point were bc breaks are potentially not so harming: We need a slice() method on the Collection for forward compatibility, the support for large and very large collections using FETCH_EXTRA would heavily benefit from a method like this. {code} /** * Extract a slice of $length elements starting at position $offset from the Collection. * * If $length is null it returns all elements from $offset to the end of the Collection. * Keys are not guaranteed to be preserved, numerical keys are re-indexed in their * order of appearance. * * @param int $offset * @param int $length * @return array */ public function slice($offset, $length = null); {code} The ArrayCollection implement would be: {code} public function slice($offset, $length = null); { return array_slice($this->_elements, $offset, $length); } {code}	Since we are still at a point were bc breaks are potentially not so harming: We need a slice() method on the Collection for forward compatibility, the support for large and very large collections using FETCH_EXTRA would heavily benefit from a method like this. {code} /** * Extract a slice of $length elements starting at position $offset from the Collection. * * If $length is null it returns all elements from $offset to the end of the Collection. * Keys have to be preserved by this method. * * @param int $offset * @param int $length * @return array */ public function slice($offset, $length = null); {code} The ArrayCollection implement would be: {code} public function slice($offset, $length = null); { return array_slice($this->_elements, $offset, $length); } {code}

Benjamin Eberlei made changes - 08/Aug/10 11:40 AM

Description

Since we are still at a point were bc breaks are potentially not so harming:

We need a slice() method on the Collection for forward compatibility, the support for large and very large collections using FETCH_EXTRA would heavily benefit from a method like this.

{code}
/**
* Extract a slice of $length elements starting at position $offset from the Collection.
*
* If $length is null it returns all elements from $offset to the end of the Collection.
* Keys have to be preserved by this method.
*
* @param int $offset
* @param int $length
* @return array
*/
public function slice($offset, $length = null);
{code}

The ArrayCollection implement would be:

{code}
public function slice($offset, $length = null);
{
return array_slice($this->_elements, $offset, $length);
}
{code}