Details
-
Type:
Bug
-
Status:
In Progress
-
Priority:
Major
-
Resolution: Unresolved
-
Affects Version/s: 2.4
-
Fix Version/s: None
-
Component/s: None
-
Labels:None
Description
__sleep should not return private parent property names (see http://php.net/__sleep) this raises notices, and also results in the value of the property being 'N' (null) instead of keeping its value.
I am unfortunately stuck having to serialize proxies in my revision tracking, as doctrine seems to be currently ignoring the fetch="EAGER" I set on the related properties.
Proxies should use the Serializable interface, and not __sleep, or not return parent property names which are private, it serves no purpose, and is not supported by PHP itself anyway.
Also, if you keep __sleep, but do not return the parent property names, then it will only include the items you return, so it would be better to simply drop the __sleep method, I cannot actually see any useful purpose it serves.
Activity
| Field | Original Value | New Value |
|---|---|---|
| Description |
__sleep should not return private property names (see http://php.net/__sleep) this raises notices, and also results in the value of the property being 'N' (null) instead of keeping its value. I am unfortunately stuck having to serialize proxies in my revision tracking, as doctrine seems to be currently ignoring the fetch="EAGER" I set on the related properties. Proxies should use the Serializable interface, and not __sleep, or not return property names which are private, it serves no purpose, and is not supported by PHP itself anyway. |
__sleep should not return private parent property names (see http://php.net/__sleep) this raises notices, and also results in the value of the property being 'N' (null) instead of keeping its value. I am unfortunately stuck having to serialize proxies in my revision tracking, as doctrine seems to be currently ignoring the fetch="EAGER" I set on the related properties. Proxies should use the Serializable interface, and not __sleep, or not return parent property names which are private, it serves no purpose, and is not supported by PHP itself anyway. Also, if you keep __sleep, but do not return the parent property names, then it will only include the items you return, so it would be better to simply drop the __sleep method, I cannot actually see any useful purpose it serves. |
| Workflow | jira [ 13562 ] | jira-feedback [ 14036 ] |
| Workflow | jira-feedback [ 14036 ] | jira-feedback2 [ 15900 ] |
| Workflow | jira-feedback2 [ 15900 ] | jira-feedback3 [ 18155 ] |
| Assignee | Benjamin Eberlei [ beberlei ] | Marco Pivetta [ ocramius ] |
| Project | Doctrine 2 - ORM [ 10032 ] | Doctrine Common [ 10043 ] |
| Key | DDC-1727 | DCOM-175 |
| Affects Version/s | 2.4 [ 10327 ] | |
| Affects Version/s | 2.2.1 [ 10194 ] | |
| Component/s | ORM [ 10012 ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
- Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=DCOM-175, expand=changesets[-21:-1].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)
just updated the issue body, realised that I worded something badly.