Doctrine Common
  1. Doctrine Common
  2. DCOM-164

@type phpdoc annotations are not ignored (@type == @var)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 2.3
    • Fix Version/s: None
    • Component/s: Annotations
    • Labels:
      None

      Description

      phpDocumentor guys wrote their own PSR to define how to use phpdoc properly (https://github.com/phpDocumentor/phpDocumentor2/blob/develop/docs/PSR.md).

      They deprecate the @var annotation and recommend using @type instead.

      The @type (phpdoc) annotation is not blacklisted/ignored by the AnnotationReader. Code that uses this annotation raises errors with Doctrine/Annotations.

      @type should be blacklisted/ignored, but may that create BC breaks for users?

        Activity

        Matthieu Napoli created issue -
        Show
        Matthieu Napoli added a comment - PR: https://github.com/doctrine/annotations/pull/2
        Matthieu Napoli made changes -
        Field Original Value New Value
        Description phpDocumentor guys wrote their own PSR to define how to use phpdoc properly.

        They deprecate the @var annotation and recommend using @type instead.

        The @type (phpdoc) annotation is not blacklisted/ignored by the AnnotationReader. Code that uses this annotation raises errors with Doctrine/Annotations.

        @type should be blacklisted/ignored, but may that create BC breaks for users?
        phpDocumentor guys wrote their own PSR to define how to use phpdoc properly (https://github.com/phpDocumentor/phpDocumentor2/blob/develop/docs/PSR.md).

        They deprecate the @var annotation and recommend using @type instead.

        The @type (phpdoc) annotation is not blacklisted/ignored by the AnnotationReader. Code that uses this annotation raises errors with Doctrine/Annotations.

        @type should be blacklisted/ignored, but may that create BC breaks for users?
        Hide
        Guilherme Blanco added a comment -

        Will not fix as phpDoc2 does not use @type anymore.

        Show
        Guilherme Blanco added a comment - Will not fix as phpDoc2 does not use @type anymore.
        Guilherme Blanco made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Assignee Benjamin Eberlei [ beberlei ] Guilherme Blanco [ guilhermeblanco ]
        Resolution Won't Fix [ 2 ]

        This list may be incomplete, as errors occurred whilst retrieving source from linked applications:

        • Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=DCOM-164, expand=changesets[0:20].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

          People

          • Assignee:
            Guilherme Blanco
            Reporter:
            Matthieu Napoli
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: