Doctrine 1

Pessimistic locking locks entire table rather than record

Details

Description

When using pessimistic locking as described in:

http://www.doctrine-project.org/projects/orm/1.2/docs/manual/component-overview:locking-manager:examples/zh

the locking manager locks the entire table rather than the specific object.

This should be clear from the attached patch which corrects the issue (assuming I have correctly interpreted the intention of pessimistic locking!).

The current behavior will have worked as expected for users but it will have locked far more than was intended and may thus have affected performance.

NB: I can confirm this works for non-composite keys but please review and test for composite keys as I have no such tables to hand.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Barry O'Donovan added a comment -

Folks - just wondering if anyone had a chance to look at this as, while not critical, it does appear to be a genuinely major performance issue.

Show
Barry O'Donovan added a comment - Folks - just wondering if anyone had a chance to look at this as, while not critical, it does appear to be a genuinely major performance issue.
Hide
Permalink
Grégoire Paris added a comment -

Duplicate with more information : http://www.doctrine-project.org/jira/browse/DC-185

Show
Grégoire Paris added a comment - Duplicate with more information : http://www.doctrine-project.org/jira/browse/DC-185

People

  • Assignee:
    Jonathan H. Wage
    Reporter:
    Barry O'Donovan
Vote (1)
Watch (2)

Dates

  • Created:
    Updated: