Doctrine 1
  1. Doctrine 1
  2. DC-864

Generating YAML schema from model should pick up also charset, collate and other options

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Import/Export, Schema Files
    • Labels:
      None

      Description

      I did change Doctrine/Export/Schema.php to pick up some options from model, then they get exported into YAML schema by current code.

      Adding the patch. (sorry, can't run the tests, so I'm not sure whether it does break something, really shouldn't)

      In my project it works just as expected (did need it for the way I do migrations).

      TODO for Doctrine devs:

      • run tests with my patch and let me know if there's a problem
      • consider other option names, which are worth of export, so far I did need "charset" and "collate", and I added "queryParts" as well.

      I hope my additions make sense and will help you to improve Doctrine project. (and that you will include it, so I don't have custom modified Doctrine )

        Activity

        Hide
        Peter Helcmanovsky added a comment -

        By hunting down an eluding bug I figured out (i.e. by hard way) that the indexes are dropped as well during YAML generation.

        I will do another pull request on github including another 3 lines to fix that...

        I see this issue is ignored anyway by core devs.

        Show
        Peter Helcmanovsky added a comment - By hunting down an eluding bug I figured out (i.e. by hard way) that the indexes are dropped as well during YAML generation. I will do another pull request on github including another 3 lines to fix that... I see this issue is ignored anyway by core devs.

          People

          • Assignee:
            Jonathan H. Wage
            Reporter:
            Peter Helcmanovsky
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated: