Doctrine 1

postHydrate not called for One to One relations, when ATTR_HYDRATE_OVERWRITE == false, and the record is cached in the table's identityMap

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Critical Critical
  • Resolution: Unresolved
  • Affects Version/s: 1.2.3
  • Fix Version/s: None
  • Component/s: Record
  • Labels:
    None
  • Environment:
    All

Description

When objects are hydrated with a join to a one to one relation, if the queried object is stored in the table's cache, and ATTR_HYDRATE_OVERWRITE set to false, then the one to one relation's postHydrate method will never be called.

This is due to this line.

 
} else if ( ! isset($prev[$parent][$relationAlias])) {

...which will always evaluate to false, and postHydrate will ever be called, as the record has been pulled from the table cache here

  1. File
    DC857TestCase.php
    03/Sep/10 11:37 AM
    2 kB
    Ben Davies
  2. Text File
    DC857.patch
    05/Sep/10 12:41 PM
    1 kB
    Ben Davies

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Ben Davies added a comment -

Test case attached.

Show
Ben Davies added a comment - Test case attached.
Hide
Permalink
Ben Davies added a comment - - edited

There needs to be some kind of caching on the pre/postHydrate calls, which is done throughout the Doctrine_Hydrator_Graph, except for when the relation is one-to-one.
This is done just above, for relations that are not one-to-one.

Unfortunately, I couldn't work out how to implement it for one-to-one.
Probably a simple fix for someone familiar with the code

Show
Ben Davies added a comment - - edited There needs to be some kind of caching on the pre/postHydrate calls, which is done throughout the Doctrine_Hydrator_Graph, except for when the relation is one-to-one. This is done just above , for relations that are not one-to-one. Unfortunately, I couldn't work out how to implement it for one-to-one. Probably a simple fix for someone familiar with the code
Hide
Permalink
Ben Davies added a comment -

Correct Test Case

Show
Ben Davies added a comment - Correct Test Case
Hide
Permalink
Ben Davies added a comment -

Correct Test Case

Show
Ben Davies added a comment - Correct Test Case
Hide
Permalink
Ben Davies added a comment -

I was probably a little too tired to think this through clearly on a Friday after a long weeks work!
Patched attached, which doesn't break any of the existing unit tests.

Show
Ben Davies added a comment - I was probably a little too tired to think this through clearly on a Friday after a long weeks work! Patched attached, which doesn't break any of the existing unit tests.

People

  • Assignee:
    Jonathan H. Wage
    Reporter:
    Ben Davies
Vote (0)
Watch (1)

Dates

  • Created:
    Updated: