Doctrine 1
  1. Doctrine 1
  2. DC-768

Renaming a NOT NULL column without a default value fails in MySQL migrations

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 1.2.2
    • Fix Version/s: None
    • Component/s: Migrations
    • Labels:
      None

      Description

      When trying to rename a column that is NOT NULL and has no default value, Doctrine generates this SQL:

      ALTER TABLE `article` CHANGE `typeid` `listid` INT DEFAULT NULL NOT NULL

      Which fails. It should be:

      ALTER TABLE `article` CHANGE `typeid` `listid` INT NOT NULL

        Activity

        Hide
        Matthew Hughes added a comment -

        Attached is a patch that solves the issue.
        It's not the most elegan solution.
        But works and all tests pass.

        Show
        Matthew Hughes added a comment - Attached is a patch that solves the issue. It's not the most elegan solution. But works and all tests pass.
        Hide
        Matthew Hughes added a comment - - edited

        can confirm this behaviour on mysql w/ 1.2.4

        Show
        Matthew Hughes added a comment - - edited can confirm this behaviour on mysql w/ 1.2.4

          People

          • Assignee:
            Jonathan H. Wage
            Reporter:
            Jack Sleight
          • Votes:
            2 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated: