Doctrine 1

[pgsql] missing quoteIdentifier() on "alter table" queries

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.2.2
  • Fix Version/s: 1.2.3
  • Component/s: Import/Export
  • Labels:
    None
  • Environment:
    PostgreSQL

Description

In Doctrine_Export_Pgsql the table name of query like "ALTER TABLE mytable ..." are not quoted even if ATTR_QUOTE_IDENTIFIER is enabled.
This create failing queries, for example if the table to alter is called 'user'.

Please note in Mysql exporter the table name of ALTER TABLE queries is correctly quoted.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Francesco Montefoschi added a comment -

Proposed test and fix on github: http://github.com/fmntf/doctrine1/tree/DC-712

Show
Francesco Montefoschi added a comment - Proposed test and fix on github: http://github.com/fmntf/doctrine1/tree/DC-712
Hide
Permalink
Jonathan H. Wage added a comment -

Thanks again for the issue and patch!

Show
Jonathan H. Wage added a comment - Thanks again for the issue and patch!

People

  • Assignee:
    Jonathan H. Wage
    Reporter:
    Francesco Montefoschi
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: