Doctrine 1
  1. Doctrine 1
  2. DC-709

Column comments are not escaped

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.2.2
    • Fix Version/s: 1.2.3
    • Component/s: Schema Files
    • Labels:
      None
    • Environment:
      MySQL 5.1.41

      Description

      Following schema.yml causes MySQL error because of the first column comment that contains the reserved ' char.

      Client:
        columns:
          serial:    { type: string(50), primary: true, comment: "Seriale dell'hardware" }
      

      The following works (note the double ''), but Doctrine schema should be automatically escaped

      Client:
        columns:
          serial:    { type: string(50), primary: true, comment: "Seriale dell''hardware" }
      

        Activity

        Hide
        John Kary added a comment -

        Confirmed and fixed with test case: http://github.com/johnkary/doctrine1/commit/640d2a11866e49b4315419ba665c4069c122e6b5
        Pull request sent.

        Show
        John Kary added a comment - Confirmed and fixed with test case: http://github.com/johnkary/doctrine1/commit/640d2a11866e49b4315419ba665c4069c122e6b5 Pull request sent.
        Hide
        Jonathan H. Wage added a comment -

        Thanks for the issue, test and patch!

        Show
        Jonathan H. Wage added a comment - Thanks for the issue, test and patch!
        Hide
        Claudio Nicora added a comment -

        You're welcome. Mine was the easiest part

        Show
        Claudio Nicora added a comment - You're welcome. Mine was the easiest part

          People

          • Assignee:
            Jonathan H. Wage
            Reporter:
            Claudio Nicora
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: