Doctrine 1
  1. Doctrine 1
  2. DC-585

Hydrate Array does not return full array, when Hydrate Scalar does

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Environment:
      OS : Ubuntu 9.04
      PHP : PHP 5.2.6-3ubuntu4.5

      Description

      Description : Upon hydrating as array I will receive one row returned. If I am to hydrate as Scalar, I will get 200+ rows. Also, if i echo the sql ($q->getSqlQuery()) and run that raw, it will also return around 200+ rows.

      $q = Doctrine_Query::create()
      ->select('DISTINCT(co.name) AS field, co.name AS value')
      ->from('Model_Country co')
      ->leftJoin('co.City ci');

      //here we will get only the first row
      $results = $q->execute(array(), Doctrine::HYDRATE_ARRAY);

      //Here we will get all 200+ rows
      $results = $q->execute(array(), Doctrine::HYDRATE_SCALAR);

      I have yet to dig to deep into this, but if it is indeed a bug, my guess is it is in Doctrine_Hydrator_Graph::hydrateResultSet()

      I can provide more data if needed.

      1. Doctrine-DC-585-b.patch
        0.7 kB
        Pierrot Evrard
      2. Doctrine-DC-585-c.patch
        0.7 kB
        Pierrot Evrard

        Activity

        James Solomon created issue -
        Hide
        James Solomon added a comment -

        I have found this in the google group, and he provides more detailed info, and appears to be the same exact issue : http://groups.google.com/group/doctrine-user/msg/8e4a8a673428fff0

        Show
        James Solomon added a comment - I have found this in the google group, and he provides more detailed info, and appears to be the same exact issue : http://groups.google.com/group/doctrine-user/msg/8e4a8a673428fff0
        Hide
        James Solomon added a comment -

        seems to be another similar issue here : http://www.doctrine-project.org/jira/browse/DC-328

        Show
        James Solomon added a comment - seems to be another similar issue here : http://www.doctrine-project.org/jira/browse/DC-328
        Hide
        Juan Antonio Galán added a comment -

        I'm having that problem and I taked a look into the code, found this:

        I have a query that looks like this:
        $q = Doctrine_Query::create()
        ->select('af.id as id, af.user_id as user')
        ->from('ActivityFeed af')
        ->innerJoin('af.user as afu')
        ->orderBy('af.time DESC');

        The sql query without aliases in SELECT or without join is built that way:
        SELECT a.id AS a_id, a.user_id AS a_user_id ... -> This is returning all the records

        The sql query with aliases in SELECT is built that way:
        SELECT a.id AS a_0, a.user_id AS a_1 FROM ... -> This is returning only one record

        In Doctrine_Hydrator_Graph::_gatherRowData, line 288 there's the following call:

        $fieldName = $table->getFieldName($last);
        Where $last is the last part of the column alias, for example "0" in "a__0". This way the call asks the table for the name of the "0" field and the table returns "0" so I think we're not getting the right field name (it must be "id").

        I'm not understanding the whole hydration process but replacing

        $fieldName = $table->getFieldName($last);

        with:

        if(isset($this->_queryComponents[ $cache[$key]['dqlAlias']]['agg']))

        { $fieldName = $table->getFieldName($this->_queryComponents[ $cache[$key]['dqlAlias']]['agg'][$last]); }

        else

        { $fieldName = $table->getFieldName($last); }

        solves the problem almost in my case.

        Hope it will help to solve the issue.

        Show
        Juan Antonio Galán added a comment - I'm having that problem and I taked a look into the code, found this: I have a query that looks like this: $q = Doctrine_Query::create() ->select('af.id as id, af.user_id as user') ->from('ActivityFeed af') ->innerJoin('af.user as afu') ->orderBy('af.time DESC'); The sql query without aliases in SELECT or without join is built that way: SELECT a.id AS a_ id, a.user_id AS a _user_id ... -> This is returning all the records The sql query with aliases in SELECT is built that way: SELECT a.id AS a_ 0, a.user_id AS a _1 FROM ... -> This is returning only one record In Doctrine_Hydrator_Graph::_gatherRowData, line 288 there's the following call: $fieldName = $table->getFieldName($last); Where $last is the last part of the column alias, for example "0" in "a__0". This way the call asks the table for the name of the "0" field and the table returns "0" so I think we're not getting the right field name (it must be "id"). I'm not understanding the whole hydration process but replacing $fieldName = $table->getFieldName($last); with: if(isset($this->_queryComponents[ $cache [$key] ['dqlAlias'] ] ['agg'] )) { $fieldName = $table->getFieldName($this->_queryComponents[ $cache[$key]['dqlAlias']]['agg'][$last]); } else { $fieldName = $table->getFieldName($last); } solves the problem almost in my case. Hope it will help to solve the issue.
        Hide
        Jonathan H. Wage added a comment -

        It seems the suggested change causes many failures in our test suite. Can you give it a try and confirm?

        Show
        Jonathan H. Wage added a comment - It seems the suggested change causes many failures in our test suite. Can you give it a try and confirm?
        Hide
        Ben Davies added a comment -

        Just commenting to say that I can confirm this bug exists. It's happening for me too.
        I will try and dig deeper when I have some time.

        Show
        Ben Davies added a comment - Just commenting to say that I can confirm this bug exists. It's happening for me too. I will try and dig deeper when I have some time.
        Hide
        Juan Antonio Galán added a comment -

        As the error is located in Doctrine_Hydrator_Graph, HYDRATE_RECORD has the same behaviour.

        I'm trying to find a solution.

        Show
        Juan Antonio Galán added a comment - As the error is located in Doctrine_Hydrator_Graph, HYDRATE_RECORD has the same behaviour. I'm trying to find a solution.
        Hide
        Ben Davies added a comment - - edited

        This only occurs if your alias your identifier field.
        Doctrine needs to know which field is the identifier to hydrate records.
        The identifier aliases is formed to x__0, and then, as other commented has found.
        Doctrine then has no way of determining which field is the identifier.

        Show
        Ben Davies added a comment - - edited This only occurs if your alias your identifier field. Doctrine needs to know which field is the identifier to hydrate records. The identifier aliases is formed to x__0, and then, as other commented has found. Doctrine then has no way of determining which field is the identifier.
        Hide
        Enrico Stahn added a comment -

        Hi everybody,

        we really need a unit test here. The provided patch breaks all aliased queries in our application. I will provide a patch and it hopefully solves your problem Juan. If not, please provide more information or add another test-method to the provided unit test.

        I had to rewrite some of the unit tests cause the order of the fields in the generated sql statement has changed due the provided patch.

        Enrico

        http://github.com/doctrine/doctrine1/commit/e3ae69c2260dae6dfbceb4e24138b2379f3da2e6#commitcomment-169495
        http://github.com/estahn/doctrine1/tree/DC-585

        Show
        Enrico Stahn added a comment - Hi everybody, we really need a unit test here. The provided patch breaks all aliased queries in our application. I will provide a patch and it hopefully solves your problem Juan. If not, please provide more information or add another test-method to the provided unit test. I had to rewrite some of the unit tests cause the order of the fields in the generated sql statement has changed due the provided patch. Enrico http://github.com/doctrine/doctrine1/commit/e3ae69c2260dae6dfbceb4e24138b2379f3da2e6#commitcomment-169495 http://github.com/estahn/doctrine1/tree/DC-585
        Hide
        Pierrot Evrard added a comment - - edited

        Hi,

        I have a little issue with this bug report...

        I'm currently using Doctrine 1.2 at revision 7691, and I've encounter a bug when select the primary key of a model with a custom alias (typically $query->addSelect( 'r.id as my_id' )), the issue was that Doctrine automatically add `r`.```id``` AS `r_1` to the select clause, in addition to the correct `r`.`id` AS `r_1` part.

        So, I've browse the code to finally found where does this strange thing comes from, and I've found it on Doctrine_Query::parseSelect() method, just at the line 663:

        // Fix for http://www.doctrine-project.org/jira/browse/DC-585
        // Add selected columns to pending fields
        if (preg_match('/^([^\(]+)\.(\'?)(.*?)(\'?)$/', $expression, $field)) {
        $this->_pendingFields[$componentAlias][$alias] = $field[3];
        }

        So I'm wonder : where does this patch is related to this bug report?

        Whatever, the bug I've encounter is very simple : the regular expression that extract the field name takes care about ' but not ´.

        You will find a patch for the bug DC-585-b in a few minutes... This patch just make the regular expression taking account of ' and ´ and also remove all useless parentheses in expression (by this way PCRE get less matches to capture and we can earn some precious microseconds).

        Also, this patch should be completed because the query still have two `r`.`id` AS `r_1` parts, that may cause some other issues with some databases...

        IMPORTANT NOTE: The previous revision 7674 of Doctrine_Query does not cause the bug encounter with the few lines of code above, just because they were not there. They really must be review.

        Loops

        Show
        Pierrot Evrard added a comment - - edited Hi, I have a little issue with this bug report... I'm currently using Doctrine 1.2 at revision 7691, and I've encounter a bug when select the primary key of a model with a custom alias (typically $query->addSelect( 'r.id as my_id' ) ), the issue was that Doctrine automatically add `r`.```id``` AS `r _ 1` to the select clause, in addition to the correct `r`.`id` AS `r _ 1` part. So, I've browse the code to finally found where does this strange thing comes from, and I've found it on Doctrine_Query::parseSelect() method, just at the line 663: // Fix for http://www.doctrine-project.org/jira/browse/DC-585 // Add selected columns to pending fields if (preg_match('/^( [^\(] +)\.(\'?)(.*?)(\'?)$/', $expression, $field)) { $this->_pendingFields [$componentAlias] [$alias] = $field [3] ; } So I'm wonder : where does this patch is related to this bug report? Whatever, the bug I've encounter is very simple : the regular expression that extract the field name takes care about ' but not ´ . You will find a patch for the bug DC-585 -b in a few minutes... This patch just make the regular expression taking account of ' and ´ and also remove all useless parentheses in expression (by this way PCRE get less matches to capture and we can earn some precious microseconds). Also, this patch should be completed because the query still have two `r`.`id` AS `r _ 1` parts, that may cause some other issues with some databases... IMPORTANT NOTE: The previous revision 7674 of Doctrine_Query does not cause the bug encounter with the few lines of code above, just because they were not there. They really must be review. Loops
        Pierrot Evrard made changes -
        Field Original Value New Value
        Attachment Doctrine-DC-585-b.patch [ 10950 ]
        Hide
        Pierrot Evrard added a comment - - edited

        Damn, the bug above was corrected during a few weeks and comes back with the new branch of Doctrine 1.2.14.

        Does anybody can re-apply the corrective patch (renamed DC-585-c), please ?

        I repeat it agin, but these few lines of code really need to be review.

        Loops

        Show
        Pierrot Evrard added a comment - - edited Damn, the bug above was corrected during a few weeks and comes back with the new branch of Doctrine 1.2.14. Does anybody can re-apply the corrective patch (renamed DC-585 -c), please ? I repeat it agin, but these few lines of code really need to be review. Loops
        Pierrot Evrard made changes -
        Attachment Doctrine-DC-585-c.patch [ 10976 ]
        Hide
        klemen nagode added a comment -

        I also have this problem .. Anyone know howt o fix it?

        $query->execute(array(), Doctrine::HYDRATE_ARRAY); // returns one row only
        $query->execute(array(), Doctrine::HYDRATE_RECORD); // returns one row only

        $query->execute(array(), Doctrine::HYDRATE_SCALAR); // returns result as expected

        Show
        klemen nagode added a comment - I also have this problem .. Anyone know howt o fix it? $query->execute(array(), Doctrine::HYDRATE_ARRAY); // returns one row only $query->execute(array(), Doctrine::HYDRATE_RECORD); // returns one row only $query->execute(array(), Doctrine::HYDRATE_SCALAR); // returns result as expected
        Hide
        klemen nagode added a comment - - edited

        I found solution for my problem:

        Table had ID field but it was not primary key. When I deleted this column, doctrine started to work as expected.

        Show
        klemen nagode added a comment - - edited I found solution for my problem: Table had ID field but it was not primary key. When I deleted this column, doctrine started to work as expected.
        Hide
        Lacton added a comment -

        I have run into the same issue.

        Using the default hydration, I get only one record.

        Using "$query->execute(array(), Doctrine::HYDRATE_SCALAR);", I get all the expected records.

        Show
        Lacton added a comment - I have run into the same issue. Using the default hydration, I get only one record. Using "$query->execute(array(), Doctrine::HYDRATE_SCALAR);", I get all the expected records.

        This list may be incomplete, as errors occurred whilst retrieving source from linked applications:

        • Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=DC-585, expand=changesets[0:20].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

          People

          • Assignee:
            Jonathan H. Wage
            Reporter:
            James Solomon
          • Votes:
            4 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated: