Doctrine 1

Make table classes suffix configurable (with patch)

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.2.1
  • Fix Version/s: 1.2.2
  • Component/s: Attributes, Import/Export
  • Labels:
    None

Description

I follow Zend Framework (PEAR) class naming conventions, and my user table class should be named User_Table instead of UserTable and be placed in User/Table.php instead of UserTable.php. Since Table suffix is hardcoded, it's not possible to do that.

I added ATTR_TABLE_CLASS_SUFFIX attribute and set it to Table by default, so that existing code is not affected. Now, if I want, I can change that prefix to _Table and be happy. The patch is attached.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jonathan H. Wage added a comment -

I like the idea, but the patch is not quite right. We should not use an attribute for this, it should just be an option in the builder. I committed a fix for this and should solve your problem.

Show
Jonathan H. Wage added a comment - I like the idea, but the patch is not quite right. We should not use an attribute for this, it should just be an option in the builder. I committed a fix for this and should solve your problem.
Hide
Permalink
Jonathan H. Wage added a comment -

Just a note, my previous comment is wrong. We do need this to be an attribute so that the Connection.php can load the tables too with the right format.

Show
Jonathan H. Wage added a comment - Just a note, my previous comment is wrong. We do need this to be an attribute so that the Connection.php can load the tables too with the right format.

People

  • Assignee:
    Jonathan H. Wage
    Reporter:
    Elnur Abdurrakhimov
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: