CLONE -generate-migrations-diff is producing bogus migrations (drops the whole database)

Kyle Spraggs added a comment - 09/Mar/10 2:51 PM This issue is NOT fixed for certain configurations of Doctrine (namely PEAR). See http://www.doctrine-project.org/jira/browse/DC-475

Martin Shopland added a comment - 22/Apr/10 6:03 AM - edited I agree, this is an issue still in 1.2.2. The problem seems to be to do with the model class name prefix, it manifests itself in Doctrine_Migration_Diff on line 190. The keys of two arrays are compared to see what needs to be changed: Unable to find source-code formatter for language: php. Available languages are: actionscript, html, java, javascript, none, sql, xhtml, xml $from = array ( 'Model_CaseStudy' => array(...), 'Model_Event' => array(...), 'Model_Group' => array(...) ); $to = array( 'CaseStudy' => array(...), 'Event' => array(...), 'Group' => array(...) ); Because none of the array keys match it assumes that the $to array are all new models and so generates the migration to drop all of $from and create all of $to; as the models have the same table names, if you run the down you end up with no tables at all. So I think we need to inject the prefix into the $to models creation process somehow, as yet I haven't figured out an effective place to do this.

Martin Shopland added a comment - 22/Apr/10 10:09 AM - edited I've got it working. Not sure how robust or appropriate this fix is: Unable to find source-code formatter for language: diff. Available languages are: actionscript, html, java, javascript, none, sql, xhtml, xml diff --git a/lib/Doctrine/Core.php b/lib/Doctrine/Core.php index ef10b6e..2fa7a73 100644 --- a/lib/Doctrine/Core.php +++ b/lib/Doctrine/Core.php @@ -664,7 +664,7 @@ class Doctrine_Core $className = $e[0]; } - if ($classPrefix) { + if ($classPrefix && $classPrefix != substr($className, 0, strlen($classPrefix))) { $className = $classPrefix . $className; } diff --git a/lib/Doctrine/Migration/Diff.php b/lib/Doctrine/Migration/Diff.php index 7f00b38..4260f27 100644 --- a/lib/Doctrine/Migration/Diff.php +++ b/lib/Doctrine/Migration/Diff.php @@ -112,7 +112,13 @@ class Doctrine_Migration_Diff $ this ->_cleanup(); $from = $ this ->_generateModels(self::$_fromPrefix, $ this ->_from); - $to = $ this ->_generateModels(self::$_toPrefix, $ this ->_to); + $to = $ this ->_generateModels( + + Doctrine_Manager::getInstance()->getAttribute(Doctrine_Core::ATTR_MODEL_CLASS_PREFIX) . + self::$_toPrefix, + + $ this ->_to + ); return $ this ->_diff($from, $to); }