Doctrine 1

synchronize records based on the primary keys, patch available

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Incomplete
  • Affects Version/s: 1.2.1
  • Fix Version/s: 1.2.2
  • Component/s: Record, Relations
  • Labels:
    None

Description

If I do a synchronizeWithArray(), the order of the elements in the array has to be the same as they are saved in the database.
Of course this can not be assumed in any situation, where you have reordered form-elements etc.

I would expect, if I add the IDs to the elements in the array, that the update-process is based on them and not on the element-order.

Please take a look at this old ticket: http://trac.doctrine-project.org/ticket/2097

The attached patch works really nice on the actual revision too.

Activity

Hide
Permalink
Jonathan H. Wage added a comment -

Hi, have you tested this patch against Doctrine 1.2 and ran the test suite? When I give it a try, it wouldn't quite apply cleanly and it seems to break lots of tests. I'll keep looking at it, let me know if you have any more information or if you have another version of the patch. Thanks, Jon

Show
Jonathan H. Wage added a comment - Hi, have you tested this patch against Doctrine 1.2 and ran the test suite? When I give it a try, it wouldn't quite apply cleanly and it seems to break lots of tests. I'll keep looking at it, let me know if you have any more information or if you have another version of the patch. Thanks, Jon

People

  • Assignee:
    Jonathan H. Wage
    Reporter:
    Marcus Häußler
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: