Improper translation of data types

Should it just be using INTEGER instead of NUMBER? It seems INTEGER is an alias for NUMBER(38) ?

Hi Jon,

an 8 byte integer has a range from -9.223.372.036.854.775.808 to 9.223.372.036.854.775.807

As far as i know there is no column type integer with oracle. I dont know if any database support unsigned 8 byte integer. NUMBER(20,0) would be the best substitution for INTEGER in my opinion.

I read here:

http://ss64.com/ora/syntax-datatypes.html

INTEGER
This ANSI datatype will be accepted by Oracle - it is actually a synonym for NUMBER(38)

This is code that maps integer to NUMBER currently. What do you think we should change this to?

            case 'int':
                $length = (!empty($field['length'])) ? $field['length'] : false;
                if ( $length && $length <= $this->conn->number_max_precision)  {
                    if ($length <= 1) {
                        return 'NUMBER(3)'; // TINYINT
                    } elseif ($length == 2) {
                        return 'NUMBER(5)'; // SMALLINT
                    } elseif ($length == 3) {
                        return 'NUMBER(8)'; // MEDIUMINT
                    } elseif ($length == 4) {
                        return 'NUMBER(10)'; // INTEGER
                    } elseif ($length <= 8) {
                        return 'NUMBER(20)'; // BIGINT
                    } else {
                        return 'NUMBER('.$length.')';
                    }
                }
                return 'INT';

Hi Jon,

never seen before but i works:

CREATE TABLE Foo (Bar INTEGER);

table created successfuly

Displaying oracle sql statement for the table:

CREATE TABLE "FOO"
( "BAR" NUMBER(*,0)
)
/

If oracle says NUMBER(38,0) is the subtype of INTEGER and SMALLINT then i would use these subtypes.

From oracle standard package:

type NUMBER is NUMBER_BASE;
subtype FLOAT is NUMBER; – NUMBER(126)
subtype REAL is FLOAT; – FLOAT(63)
subtype "DOUBLE PRECISION" is FLOAT;
subtype INTEGER is NUMBER(38,0);
subtype INT is INTEGER;
subtype SMALLINT is NUMBER(38,0);
subtype DECIMAL is NUMBER(38,0);
subtype NUMERIC is DECIMAL;
subtype DEC is DECIMAL;

subtype BINARY_INTEGER is INTEGER range '-2147483647'..2147483647;
subtype NATURAL is BINARY_INTEGER range 0..2147483647;
subtype NATURALN is NATURAL not null;
subtype POSITIVE is BINARY_INTEGER range 1..2147483647;
subtype POSITIVEN is POSITIVE not null;
subtype SIGNTYPE is BINARY_INTEGER range '-1'..1;

Can you help me out with the code In Doctrine_DataDict_Oracle::getNativeDeclaration(), can you help me come up with are the best native types to translate the portable Doctrine types to.

Thanks!