Doctrine 1

Identifier Quoting not made in generated subquery

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0.12, 1.1.4, 1.1.5
  • Fix Version/s: 1.2.0-RC1
  • Component/s: Query
  • Labels:
    None
  • Environment:
    Linux, Oracle 10g

Description

If identifier quoting is enabled doctrine does not perform quoting in some subqueries.

$this->_conn->quoteIdentifier has to be added twice as below in query.php line 1426:

$subquery = 'SELECT doctrine_subquery_alias.' . $this->_conn->quoteIdentifier($table->getColumnName($table->getIdentifier()))

    . ' FROM (' . $subquery . ') doctrine_subquery_alias'
    . ' GROUP BY doctrine_subquery_alias.' . $this->_conn->quoteIdentifier($table->getColumnName($table->getIdentifier()))
    . ' ORDER BY MIN(ROWNUM)';

Activity

Ascending order - Click to sort in descending order
Jonathan H. Wage made changes -
Field Original Value New Value
Description If identifier quoting is enabled doctrine does not perform quoting in some subqueries.

$this->_conn->quoteIdentifier has to be added twice as below in query.php line 1426:

$subquery = 'SELECT doctrine_subquery_alias.' . $this->_conn-
>quoteIdentifier($table->getColumnName($table->getIdentifier()))

    . ' FROM (' . $subquery . ') doctrine_subquery_alias'
    . ' GROUP BY doctrine_subquery_alias.' . $this->_conn-
>quoteIdentifier($table->getColumnName($table->getIdentifier()))

    . ' ORDER BY MIN(ROWNUM)'; 		If identifier quoting is enabled doctrine does not perform quoting in some subqueries.

$this->_conn->quoteIdentifier has to be added twice as below in query.php line 1426:

{code}
$subquery = 'SELECT doctrine_subquery_alias.' . $this->_conn->quoteIdentifier($table->getColumnName($table->getIdentifier()))

    . ' FROM (' . $subquery . ') doctrine_subquery_alias'
    . ' GROUP BY doctrine_subquery_alias.' . $this->_conn->quoteIdentifier($table->getColumnName($table->getIdentifier()))
    . ' ORDER BY MIN(ROWNUM)';
{code}
Assignee Guilherme Blanco [ guilhermeblanco ] Jonathan H. Wage [ jwage ]
Jonathan H. Wage made changes -
Status Open [ 1 ] Closed [ 6 ]
Fix Version/s 1.2.0-RC1 [ 10041 ]
Resolution Fixed [ 1 ]
Thomas Wahle made changes -
Resolution Fixed [ 1 ]
Status Closed [ 6 ] Reopened [ 4 ]
Jonathan H. Wage made changes -
Status Reopened [ 4 ] Closed [ 6 ]
Resolution Fixed [ 1 ]

People

  • Assignee:
    Jonathan H. Wage
    Reporter:
    Thomas Wahle
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: