Doctrine 1
  1. Doctrine 1
  2. DC-233

Versionable behavior should specify relation alias

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.2.0-ALPHA1, 1.2.0-ALPHA2, 1.2.0-ALPHA3, 1.2.0-BETA1, 1.2.0-BETA2, 1.2.0-BETA3
    • Fix Version/s: 1.2.0
    • Component/s: Behaviors, Relations
    • Labels:
      None

      Description

      I18n behavior sets a nice name for the relation to the translation table, so why Versionable behavior doesn't do the same?

      Proposed patch is not only repeats this behavior, but also allows the user to specify custom name for the relation.

      See also DC-227.

      1. DC-233.patch
        1.0 kB
        Eugene Janusov
      2. DC-233.v2.patch
        0.5 kB
        Eugene Janusov

        Activity

        Hide
        Eugene Janusov added a comment -

        Proposed patch attached.

        Show
        Eugene Janusov added a comment - Proposed patch attached.
        Hide
        Eugene Janusov added a comment -

        Jonathan,

        Why don't you like this change? Regardless of DC-227, the ability to specify relation alias for the versioning table would be useful.

        Show
        Eugene Janusov added a comment - Jonathan, Why don't you like this change? Regardless of DC-227 , the ability to specify relation alias for the versioning table would be useful.
        Hide
        Eugene Janusov added a comment -

        Attached version 2 of the patch with hardcoded relation alias.

        Show
        Eugene Janusov added a comment - Attached version 2 of the patch with hardcoded relation alias.

          People

          • Assignee:
            Jonathan H. Wage
            Reporter:
            Eugene Janusov
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: