Doctrine 1
  1. Doctrine 1
  2. DC-162

Doctrine_Migration_Builder fail to buildChangeColumn()

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 1.2.0-ALPHA3
    • Fix Version/s: 1.2.0-BETA1
    • Component/s: Migrations
    • Labels:
      None
    • Environment:
      Symfony 1.3 daily svn

      Description

      Doctrine_Migration_Builder->buildChangeColumn contains a simple error.

      return "        \$this->changeColumn('" . $tableName . "', '" . $columnName. "', '" . $length . "', '" . $type . "', " . $this->varExport($column) . ");";
      

      When I look Doctrine_Migration_Base->changeColumn declaration, i see

      public function changeColumn($tableName, $columnName, $type = null, $length = null, array $options = array())
      

      The $length and $type parameters are inverted. It makes all column changes fail.

      Thank you for your work, Doctrine is great !

        Activity

        Hide
        Jonathan H. Wage added a comment -

        This has already been fixed in another issue/commit.

        Show
        Jonathan H. Wage added a comment - This has already been fixed in another issue/commit.

          People

          • Assignee:
            Jonathan H. Wage
            Reporter:
            thibault duplessis
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: