Doctrine 1

records are not update when joining a relatoin and this relation was joined before

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Incomplete
  • Affects Version/s: 1.1.4
  • Fix Version/s: 1.1.4
  • Component/s: Record
  • Labels:
    None
  • Environment:
    Mac OSX, Apache 2, PHP 5.3

Description

i have already resolved the bug in Doctrine/Hytrator.php but i don't comit that because i have no access

the recourds now would be updated when State said that record is not complete and not locked

Attached svn_status

Index: Doctrine/Hydrator.php
===================================================================
--- Doctrine/Hydrator.php	(revision 6574)
+++ Doctrine/Hydrator.php	(working copy)
@@ -232,7 +232,7 @@
                         $indexExists = isset($identifierMap[$path][$id[$parent]][$id[$dqlAlias]]);
                         $index = $indexExists ? $identifierMap[$path][$id[$parent]][$id[$dqlAlias]] : false;
                         $indexIsValid = $index !== false ? isset($prev[$parent][$relationAlias][$index]) : false;
-                        if ( ! $indexExists || ! $indexIsValid) {
+                        if ( ! $indexExists || ! $indexIsValid || !in_array($prev[$parent][$relationAlias][$index]->state(), array(Doctrine_Record::STATE_CLEAN, Doctrine_Record::STATE_TCLEAN, Doctrine_Record::STATE_LOCKED, Doctrine_Record::STATE_TLOCKED))) {
                             $element = $driver->getElement($data, $componentName);
                             $event->set('data', $element);
                             $listeners[$componentName]->postHydrate($event);
@@ -258,7 +258,8 @@
                     $oneToOne = true;
                     if ( ! isset($nonemptyComponents[$dqlAlias]) && ! isset($prev[$parent][$relationAlias])) {
                         $prev[$parent][$relationAlias] = $driver->getNullPointer();
-                    } else if ( ! isset($prev[$parent][$relationAlias])) {
+                    } else if ( ! isset($prev[$parent][$relationAlias]) || !in_array($prev[$parent][$relationAlias]->state(), array(Doctrine_Record::STATE_CLEAN, Doctrine_Record::STATE_TCLEAN, Doctrine_Record::STATE_LOCKED, Doctrine_Record::STATE_TLOCKED))) {
+                    	
                         $element = $driver->getElement($data, $componentName);
 
 						// [FIX] Tickets #1205 and #1237

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jonathan H. Wage added a comment -

I want to commit your patch but I don't understand it or understand what is broken without it. Can you show a failing test case for it?

Show
Jonathan H. Wage added a comment - I want to commit your patch but I don't understand it or understand what is broken without it. Can you show a failing test case for it?
Hide
Permalink
Jonathan H. Wage added a comment -

Also, your patch breaks our test suite so try your patches against our test suite before adding it to a ticket or anything.

Show
Jonathan H. Wage added a comment - Also, your patch breaks our test suite so try your patches against our test suite before adding it to a ticket or anything.
Hide
Permalink
Ronald Marske added a comment -

I have to try write a Testcase and found a Problem by Fetching Doctrine Record. So i can`t write a Testcase for this Problem so long HYDRATE_RECORD returns all Fields when i select only one. See Ticket DC-174

Show
Ronald Marske added a comment - I have to try write a Testcase and found a Problem by Fetching Doctrine Record. So i can`t write a Testcase for this Problem so long HYDRATE_RECORD returns all Fields when i select only one. See Ticket DC-174
Hide
Permalink
Jonathan H. Wage added a comment -

HYDRATE_RECORD doesn't return all fields. The toArray() previously would lazily load the column values even if you did not select them.

Show
Jonathan H. Wage added a comment - HYDRATE_RECORD doesn't return all fields. The toArray() previously would lazily load the column values even if you did not select them.

People

  • Assignee:
    Jonathan H. Wage
    Reporter:
    Ronald Marske
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: