Doctrine 1

Doctrine_Export_Oracle::alterTable() not properly quoting column identifier for change

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 1.2.2, 1.2.3, 1.2.4
  • Fix Version/s: None
  • Component/s: Import/Export
  • Labels:
    None

Description

This bug was introduced by the person reporting the bug #DC-592.

When trying to generate an ALTER TABLE statement with Doctrine_Core::ATTR_QUOTE_IDENTIFIER enabled, the column identifier is not quoted, and a blank identifier is instead quoted, generating the following SQL:

ALTER TABLE "mytable" MODIFY (username "" VARCHAR2(200))

The proper SQL to be generated should be:

ALTER TABLE "mytable" MODIFY ("username" VARCHAR2(200))

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
John Kary added a comment -

Pull request opened with failing test case and bug fix:
https://github.com/doctrine/doctrine1/pull/40

Show
John Kary added a comment - Pull request opened with failing test case and bug fix: https://github.com/doctrine/doctrine1/pull/40
John Kary made changes -
Field Original Value New Value
Affects Version/s 1.2.3 [ 10051 ]
Affects Version/s 1.2.2 [ 10047 ]
This list may be incomplete, as errors occurred whilst retrieving source from linked applications:
  • Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=DC-1036, expand=changesets[-21:-1].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

People

  • Assignee:
    Jonathan H. Wage
    Reporter:
    John Kary
Vote (0)
Watch (0)

Dates

  • Created:
    Updated: