Doctrine 1
  1. Doctrine 1
  2. DC-1032

[PATCH] Doctrine_Collection::isModified() does not support deep like Doctrine_Record but probably should

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Trivial Trivial
    • Resolution: Unresolved
    • Affects Version/s: 1.2.3
    • Fix Version/s: None
    • Component/s: Relations
    • Labels:
      None

      Description

      $record instanceof Doctrine_Record;
      $collection instanceof Doctrine_Collection;

      Using the $record object I can find out if it has been modified : $record->isModified().
      I can also have this check all the relations also by passing true : $record->isModified(true);

      However, the $collection object only support the first level and not the relations of its member records,
      $collection->isModified() returns false if one of the entry has one its relations modified (as it should).

      The improvement would be to allow this method to accept true, like it's $record counterpart, which would return true instead.

      See attached patch.

        Activity

        There are no comments yet on this issue.

          People

          • Assignee:
            Roman S. Borschel
            Reporter:
            Christian Roy
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated: