Doctrine DBAL
  1. Doctrine DBAL
  2. DBAL-968

SQL Server modifyLimitQuery broken

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Critical Critical
    • Resolution: Unresolved
    • Affects Version/s: 2.5
    • Fix Version/s: None
    • Component/s: Drivers, Platforms
    • Security Level: All
    • Environment:
      SQL Server

      Description

      The recent change to SQLServerPlatform.php @jaylinski:improved sqlserver 'doModifyLimitQuery' select-from pattern broke the ORM Paginator's queries on SQL server.

      I investigated, and found that some of the test cases for the SQL Server platform weren't actually correct SQL. Also, there were no test cases that covered what the paginator is doing, so I've written test cases for those. I will open a pull request for this issue.

      The modifyLimitQuery method in SQLServerPlatform.php should be fixed to pass the fixed old tests and the new tests.

      My concern is that that method is becoming too complex, but that's an issue for another day.

        Activity

        Hide
        Marco Pivetta added a comment -

        I'm gonna cry. Thank you, MSSQL, you make our lives so much "easier"

        Show
        Marco Pivetta added a comment - I'm gonna cry. Thank you, MSSQL, you make our lives so much "easier"

          People

          • Assignee:
            Benjamin Eberlei
            Reporter:
            William Schaller
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated: