Doctrine DBAL
  1. Doctrine DBAL
  2. DBAL-927

[GH-622] improved sqlserver 'doModifyLimitQuery' select-from pattern

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5
    • Component/s: None
    • Security Level: All
    • Labels:
      None

      Description

      This issue is created automatically through a Github pull request on behalf of jaylinski:

      Url: https://github.com/doctrine/dbal/pull/622

      Message:

      the current regex-pattern in the `doModifyLimitQuery`-function is very slow and buggy for my sqlserver queries.
      i think the slowness is a result from the atomic-group inside the regex.

      I tried to improve it, but since I'm not an regex-expert at all, I don't know if the 'fix' satisfies all needs.
      the unit-tests returned ok.

      it would be perfect if someone with some regex-knowledge would have a look at this before merging it.

        Issue Links

          Activity

          Hide
          Doctrine Bot added a comment -

          A related Github Pull-Request [GH-622] was closed:
          https://github.com/doctrine/dbal/pull/622

          Show
          Doctrine Bot added a comment - A related Github Pull-Request [GH-622] was closed: https://github.com/doctrine/dbal/pull/622

            People

            • Assignee:
              Marco Pivetta
              Reporter:
              Doctrine Bot
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: