Doctrine DBAL

orm:convert-mapping SchemaException on Postgres reserved words

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0.2, 2.1
  • Component/s: Schema Managers
  • Labels:
    None
  • Environment:
    CentOs 5.5, Postgres 8.1.22

Description

While execuiting

doctrine orm:convert-mapping --from-database yml /tmp/test.yml

I get presented an error

[Doctrine\DBAL\Schema\SchemaException]
Invalid index-name tablename_"input"_idx given, has to be [a-zA-Z0-9_]

The index "type" is quoted because this is a reserved word in Postgres. for example see the following definition:

FOREIGN KEY (something) REFERENCES somethings(id) ON UPDATE CASCADE
FOREIGN KEY (another) REFERENCES anothers(id) ON UPDATE CASCADE
FOREIGN KEY ("type") REFERENCES logtypes(id) ON UPDATE CASCADE

Only type will be quoted because it is a reserved word.

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. DBAL-88 MySqlPlatform not escaping table names

  • Major - Major loss of function.
  • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Benjamin Eberlei added a comment -

You have to quote with `` in Doctrine. That is translated to the underyling vendor quotation signs.

Show
Benjamin Eberlei added a comment - You have to quote with `` in Doctrine. That is translated to the underyling vendor quotation signs.
Hide
Permalink
Emil added a comment -

@benjamin this considers a mapping error from database (Postgres) to YAML through the doctrine commandline tool, I do not think your comment is relevant for this issue.

Show
Emil added a comment - @benjamin this considers a mapping error from database (Postgres) to YAML through the doctrine commandline tool, I do not think your comment is relevant for this issue.
Hide
Permalink
Benjamin Eberlei added a comment -

@Emil it is, are you quoting the reserved word in the YML file using `` ? DBAL has some logic to fix escaping in these cases.

Show
Benjamin Eberlei added a comment - @Emil it is, are you quoting the reserved word in the YML file using `` ? DBAL has some logic to fix escaping in these cases.
Hide
Permalink
Emil added a comment -

@benjamin uhm, I might be baffled with the complexity of Doctrine or just plain wrong. But I'm trying to create a YML file from my database. How can I be making a mistake in the YML file with quotes?

The error message is presented because the Dcotrine ORM module tries to generate index names on columns, based on the database schema, but fails because the returned names (from the database schema) contain quotes (because they are reserved words).

Show
Emil added a comment - @benjamin uhm, I might be baffled with the complexity of Doctrine or just plain wrong. But I'm trying to create a YML file from my database. How can I be making a mistake in the YML file with quotes? The error message is presented because the Dcotrine ORM module tries to generate index names on columns, based on the database schema, but fails because the returned names (from the database schema) contain quotes (because they are reserved words).
Hide
Permalink
Benjamin Eberlei added a comment -

Sorry, now i get it. I didnt relaize the usecase you were applying. Yes you are right

Show
Benjamin Eberlei added a comment - Sorry, now i get it. I didnt relaize the usecase you were applying. Yes you are right
Hide
Permalink
Benjamin Eberlei added a comment -

Can you give me an Example Postgresql Schema with DDL SQL that produces this error?

Show
Benjamin Eberlei added a comment - Can you give me an Example Postgresql Schema with DDL SQL that produces this error?
Hide
Permalink
Emil added a comment -

These are the table creation for a test table which is able to reproduce the error.

Show
Emil added a comment - These are the table creation for a test table which is able to reproduce the error.
Hide
Permalink
Emil added a comment -

I hope this is enough information. The attached SQL reproduces the following error:

  1. doctrine orm:convert-mapping --from-database yml /tmp/test.yml

[Doctrine\DBAL\Schema\SchemaException]
Invalid index-name something_"input"_idx given, has to be [a-zA-Z0-9_]

orm:convert-mapping [--filter="..."] [--from-database] [-extend[="..."]] [-num-spaces[="..."]] [-h|--help] [-q|--quiet] [-v|--verbose] [-V|--version] [-a|--ansi] [-n|--no-interaction] command to-type dest-path

Show
Emil added a comment - I hope this is enough information. The attached SQL reproduces the following error: doctrine orm:convert-mapping --from-database yml /tmp/test.yml [Doctrine\DBAL\Schema\SchemaException] Invalid index-name something_"input"_idx given, has to be [a-zA-Z0-9_] orm:convert-mapping [--filter="..."] [--from-database] [- extend [="..."] ] [ -num-spaces [="..."] ] [-h|--help] [-q|--quiet] [-v|--verbose] [-V|--version] [-a|--ansi] [-n|--no-interaction] command to-type dest-path
Hide
Permalink
Benjamin Eberlei added a comment -

I can't reproduce it

Can you run the command with --verbose ? Additionally in lib/Doctrine/ORM/Tools/Console/Command/ConvertMappingCommand.php can you var_dump() $metadata after line 119?

Show
Benjamin Eberlei added a comment - I can't reproduce it Can you run the command with --verbose ? Additionally in lib/Doctrine/ORM/Tools/Console/Command/ConvertMappingCommand.php can you var_dump() $metadata after line 119?
Hide
Permalink
Benjamin Eberlei added a comment -

Ok i could reproduce it now. Input is not a keyword for me though, type also not. Coudl reproduce it with "table"

Show
Benjamin Eberlei added a comment - Ok i could reproduce it now. Input is not a keyword for me though, type also not. Coudl reproduce it with "table"
Hide
Permalink
Benjamin Eberlei added a comment -

Ok, this is a DBAL issue.

Show
Benjamin Eberlei added a comment - Ok, this is a DBAL issue.
Hide
Permalink
Benjamin Eberlei added a comment -

This is fixed and will be included in 2.0.2

Show
Benjamin Eberlei added a comment - This is fixed and will be included in 2.0.2

People

  • Assignee:
    Benjamin Eberlei
    Reporter:
    Emil
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: