Uploaded image for project: 'Doctrine DBAL'
  1. Doctrine DBAL
  2. DBAL-871

[GH-569] Fixed type and initialization value of $_nestTransactionsWithSavepoints

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5
    • Component/s: None
    • Security Level: All
    • Labels:
      None

      Description

      This issue is created automatically through a Github pull request on behalf of BenMorel:

      Url: https://github.com/doctrine/dbal/pull/569

      Message:

      `Connection::$_nestTransactionsWithSavepoints` is definitely a `boolean` and not an `integer`, and the rest of the code assumes it's `false` by default, whereas it's actually `null` right now. Which still works as `null` evaluates as `false`, but is not clean.

        Activity

        Hide
        doctrinebot Doctrine Bot added a comment -

        A related Github Pull-Request [GH-569] was closed:
        https://github.com/doctrine/dbal/pull/569

        Show
        doctrinebot Doctrine Bot added a comment - A related Github Pull-Request [GH-569] was closed: https://github.com/doctrine/dbal/pull/569
        Hide
        guilhermeblanco Guilherme Blanco added a comment -

        Issue got merged

        Show
        guilhermeblanco Guilherme Blanco added a comment - Issue got merged

          People

          • Assignee:
            guilhermeblanco Guilherme Blanco
            Reporter:
            doctrinebot Doctrine Bot
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: