Doctrine DBAL
  1. Doctrine DBAL
  2. DBAL-855

[GH-560] Fix DateTimeTz type compatibility on SQL Anywhere versions < 12

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5
    • Component/s: None
    • Security Level: All
    • Labels:
      None

      Description

      This issue is created automatically through a Github pull request on behalf of deeky666:

      Url: https://github.com/doctrine/dbal/pull/560

      Message:

      SQL Anywhere versions < 12 do not support a native date time with timezone type. Therefore the fallback strategy is to use the normal date time type. However the format of the date time tz type declaration has to correspond to the normal date time type declaration, too then.

      `getDateTimeTzTypeDeclarationSQL()` -> `getDateTimeTypeDeclarationSQL()`
      `getDateTimeTzFormatString()` -> `getDateTimeFormatString()`

      I thought about changing that in the `AbstractPlatform` but I am not sure if that might break assumptions in userland code and therefore BC. So I left the implementation SQL Anywhere specific.

        Activity

        Hide
        Doctrine Bot added a comment -

        A related Github Pull-Request [GH-560] was closed:
        https://github.com/doctrine/dbal/pull/560

        Show
        Doctrine Bot added a comment - A related Github Pull-Request [GH-560] was closed: https://github.com/doctrine/dbal/pull/560
        Show
        Marco Pivetta added a comment - Merged: https://github.com/doctrine/dbal/commit/ea5ac9588c95c117590de185434ae4adc9020388

          People

          • Assignee:
            Marco Pivetta
            Reporter:
            Doctrine Bot
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: