Doctrine DBAL
  1. Doctrine DBAL
  2. DBAL-76

PostgreSQL Platform list* SQL code is in need of serious love

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      The Postgres Schema code is very hard to read and inconsistent across the board. Some use pg_class, some pg_tables. Namespaces /Schema are not always properly checked for. There should be a really unified way on how to approach schema query issues.

        Activity

        Benjamin Eberlei created issue -
        Hide
        Denis added a comment -

        I'm not sure what this ticket is about exactly, but...

        "Namespaces /Schema are not always properly checked for."

        Usually, one would not want to specify them and set the search_path instead. Or are you meaning the schema analysis queries used internally? (If so, yes, it kind of sucks in that case, but note that there are a bunch of *_is_visible() methods, e.g. pg_catalog.pg_table_is_visible(rel.oid) which will strip out invisible schemas directly. This may be simpler than injecting schema references all over the place in that it also processes permissions.)

        Also, note that PG has a whole bunch of pg_catalog views, which are available in the information_schema.

        Show
        Denis added a comment - I'm not sure what this ticket is about exactly, but... "Namespaces /Schema are not always properly checked for." Usually, one would not want to specify them and set the search_path instead. Or are you meaning the schema analysis queries used internally? (If so, yes, it kind of sucks in that case, but note that there are a bunch of *_is_visible() methods, e.g. pg_catalog.pg_table_is_visible(rel.oid) which will strip out invisible schemas directly. This may be simpler than injecting schema references all over the place in that it also processes permissions.) Also, note that PG has a whole bunch of pg_catalog views, which are available in the information_schema.
        Benjamin Eberlei made changes -
        Field Original Value New Value
        Workflow jira [ 12220 ] jira-feedback2 [ 17566 ]
        Benjamin Eberlei made changes -
        Workflow jira-feedback2 [ 17566 ] jira-feedback3 [ 19920 ]

        This list may be incomplete, as errors occurred whilst retrieving source from linked applications:

        • Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=DBAL-76, expand=changesets[0:20].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

          People

          • Assignee:
            Benjamin Eberlei
            Reporter:
            Benjamin Eberlei
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated: