Doctrine DBAL
  1. Doctrine DBAL
  2. DBAL-74

OracleSchemaManager - incorrectly detected the length of the string columns

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-RC1-RC3
    • Fix Version/s: 2.0-RC5
    • Component/s: None
    • Labels:
      None

      Description

      When I create a VARCHAR2 column with the length specified in char units (VARCHAR2(10 CHAR)) instead of the default byte, the metadata stored in all_tab_columns -> data_length is not 10, but 40. It is better to use char_length instead of data_length. Char_length is the same wheter the size unit is in CHAR or BYTE.

      It is neccessary for me to use CHAR instead of the default BYTE, because I am using unicode charset.

        Activity

        Miloslav "adrive" Kmet created issue -
        Show
        Miloslav "adrive" Kmet added a comment - https://github.com/milokmet/dbal/commit/a5087e8e229bfd2cde947e1d387ebe2e2b122b85
        Hide
        Benjamin Eberlei added a comment -

        Can I appoint you to Doctrine's Oracle specialist?

        Thank you very much, I will merge that as soon as i have time.

        Show
        Benjamin Eberlei added a comment - Can I appoint you to Doctrine's Oracle specialist? Thank you very much, I will merge that as soon as i have time.
        Hide
        Benjamin Eberlei added a comment -

        Merged

        Show
        Benjamin Eberlei added a comment - Merged
        Benjamin Eberlei made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 2.0-RC4 [ 10111 ]
        Resolution Fixed [ 1 ]
        Benjamin Eberlei made changes -
        Fix Version/s 2.0-RC5 [ 10113 ]
        Fix Version/s 2.0-RC4 [ 10111 ]
        Benjamin Eberlei made changes -
        Workflow jira [ 12199 ] jira-feedback2 [ 17684 ]
        Benjamin Eberlei made changes -
        Workflow jira-feedback2 [ 17684 ] jira-feedback3 [ 20039 ]

        This list may be incomplete, as errors occurred whilst retrieving source from linked applications:

        • Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=DBAL-74, expand=changesets[0:20].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

          People

          • Assignee:
            Benjamin Eberlei
            Reporter:
            Miloslav "adrive" Kmet
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: