Doctrine DBAL
  1. Doctrine DBAL
  2. DBAL-692

[GH-436] phpdoc in Table::addForeignKey() update

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5
    • Component/s: None
    • Security Level: All
    • Labels:
      None

      Description

      This issue is created automatically through a Github pull request on behalf of velosipedist:

      Url: https://github.com/doctrine/dbal/pull/436

      Message:

      Added significant typehint in PhpDoc: `$foreignTable` param in `addForeignKeyConstraint()` can be just string name of table.

      It unobvious in IDE hinting and treated as wrong param. It even can confuse developer, forcing him use foreign keys additions only using existing tables. That was my case, for example :confused: Lost time till found out, that Table schema not necessary to exist for Foreign Key referring .

        Activity

        Hide
        Doctrine Bot added a comment -

        A related Github Pull-Request [GH-436] was closed:
        https://github.com/doctrine/dbal/pull/436

        Show
        Doctrine Bot added a comment - A related Github Pull-Request [GH-436] was closed: https://github.com/doctrine/dbal/pull/436

          People

          • Assignee:
            Benjamin Eberlei
            Reporter:
            Doctrine Bot
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: