Doctrine DBAL
  1. Doctrine DBAL
  2. DBAL-653

[GH-402] Fix WriteTest for platforms supporting both sequences and identity columns

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5
    • Component/s: None
    • Security Level: All
    • Labels:
      None

      Description

      This issue is created automatically through a Github pull request on behalf of deeky666:

      Url: https://github.com/doctrine/dbal/pull/402

      Message:

      The test `WriteTest::testLastInsertIdNoSequenceGiven()` does not work if the tested platform supports both sequences and identity columns and when the driver is able to return distinguished information about the last inserted sequence ID and identity column ID.
      The problem here is that both sequence IDs and identity column IDs get inserted into the database in the tests before. Therefore a driver that is capable of distinguishing between last inserted sequence and identity column IDs returns the last inserted identity column ID when `Connection::lastInsertId(null)` is called in this particular test.
      The behaviour of `Connection:lastInsertId()` is very inconsistent throughout the drivers and therefore a true expectation can only be made if the tested platform supports sequences but not identity columns.

        Activity

        Hide
        Doctrine Bot added a comment -

        A related Github Pull-Request [GH-402] was closed:
        https://github.com/doctrine/dbal/pull/402

        Show
        Doctrine Bot added a comment - A related Github Pull-Request [GH-402] was closed: https://github.com/doctrine/dbal/pull/402

          People

          • Assignee:
            Benjamin Eberlei
            Reporter:
            Doctrine Bot
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: