Doctrine DBAL
  1. Doctrine DBAL
  2. DBAL-617

[GH-380] Fix schema comparison with FK that contain quoted column names.

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5, 2.4.2
    • Component/s: None
    • Security Level: All
    • Labels:
      None

      Description

      In case `QuoteStrategy` decides to quote column names for FK, schema comparator (and in effect - schema tool), will be stuck in an `ALTER TABLE * DROP FOREIGN KEY` loop, because it doesn't recognise old indexes with matching column names.

      The problem lies inside Comparator, which relied on column names that might or might not be quoted (depending on platform, schema and dbal settings). The comparison must be performed on *unquoted* column names both ways, as it is already performed for normal indexes, table names and columns names.

        Activity

        Hide
        Doctrine Bot added a comment -

        A related Github Pull-Request [GH-380] was closed:
        https://github.com/doctrine/dbal/pull/380

        Show
        Doctrine Bot added a comment - A related Github Pull-Request [GH-380] was closed: https://github.com/doctrine/dbal/pull/380

          People

          • Assignee:
            Benjamin Eberlei
            Reporter:
            Doctrine Bot
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: