Doctrine DBAL

Schema tool does not see difference between onDelete="NO ACTION" and onDelete="RESTRICT"

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: Schema Managers
  • Labels:
    None

Description

If database has ON DELETE CASCADE, schema tool detects change to NO ACTION and RESCRICT.
If database has ON DELETE RESCRICT, schema tool detects change only in case of CASCADE.
If database has ON DELETE NO ACTION, schema tool detect change only in case of CASCADE.

Detecting of changes is done by:
doctrine orm:schema-tool update --dump-sql
and
doctrine orm:validate-schema

Activity

Ascending order - Click to sort in descending order
Roman S. Borschel made changes -
Field Original Value New Value
Assignee Roman S. Borschel [ romanb ] Benjamin Eberlei [ beberlei ]
Hide
Permalink
Benjamin Eberlei added a comment -

which database version do yo uuse? can you paste an example schema?

Show
Benjamin Eberlei added a comment - which database version do yo uuse? can you paste an example schema?
Hide
Permalink
Jan Obrátil added a comment -

This is example script with 2 testing entities.

Show
Jan Obrátil added a comment - This is example script with 2 testing entities.
Jan Obrátil made changes -
Attachment Example.php [ 10736 ]
Hide
Permalink
Jan Obrátil added a comment -

I have attached script with two entities.

I have this database version:
$ mysql --version
mysql Ver 14.14 Distrib 5.1.41, for debian-linux-gnu (i486) using readline 6.1

Check line 44. There is CASCADE.
Updating schema by: $ doctrine orm:schema-tool:update

Change CASCADE to NO ACTION
$ doctrine orm:schema-tool:update --dump-sql
ALTER TABLE ArticleItem DROP FOREIGN KEY ArticleItem_ibfk_1;
ALTER TABLE ArticleItem ADD FOREIGN KEY (articleGroupId) REFERENCES ArticleGroup(id) ON DELETE NO ACTION

everything ok, so: $ doctrine orm:schema-tool:update

Change NO ACTION to RESTRICT
$ doctrine orm:schema-tool:update --dump-sql
// no output!!

Change RESTRICT to CASCADE
$ doctrine orm:schema-tool:update --dump-sql
ALTER TABLE ArticleItem DROP FOREIGN KEY ArticleItem_ibfk_1;
ALTER TABLE ArticleItem ADD FOREIGN KEY (articleGroupId) REFERENCES ArticleGroup(id) ON DELETE CASCADE

everything ok, so: $ doctrine orm:schema-tool:update

Change CASCADE to RESTRICT
$ doctrine orm:schema-tool:update --dump-sql
ALTER TABLE ArticleItem DROP FOREIGN KEY ArticleItem_ibfk_1;
ALTER TABLE ArticleItem ADD FOREIGN KEY (articleGroupId) REFERENCES ArticleGroup(id) ON DELETE RESTRICT

everything ok, do: $ doctrine orm:schema-tool:update

Change RESTRICT to NO ACTION
$ doctrine orm:schema-tool:update --dump-sql
// no output!!

So there is no way to update database schema from RESTRICT to NO ACTION and reverse!

Show
Jan Obrátil added a comment - I have attached script with two entities. I have this database version: $ mysql --version mysql Ver 14.14 Distrib 5.1.41, for debian-linux-gnu (i486) using readline 6.1 Check line 44. There is CASCADE. Updating schema by: $ doctrine orm:schema-tool:update Change CASCADE to NO ACTION $ doctrine orm:schema-tool:update --dump-sql ALTER TABLE ArticleItem DROP FOREIGN KEY ArticleItem_ibfk_1; ALTER TABLE ArticleItem ADD FOREIGN KEY (articleGroupId) REFERENCES ArticleGroup(id) ON DELETE NO ACTION everything ok, so: $ doctrine orm:schema-tool:update Change NO ACTION to RESTRICT $ doctrine orm:schema-tool:update --dump-sql // no output!! Change RESTRICT to CASCADE $ doctrine orm:schema-tool:update --dump-sql ALTER TABLE ArticleItem DROP FOREIGN KEY ArticleItem_ibfk_1; ALTER TABLE ArticleItem ADD FOREIGN KEY (articleGroupId) REFERENCES ArticleGroup(id) ON DELETE CASCADE everything ok, so: $ doctrine orm:schema-tool:update Change CASCADE to RESTRICT $ doctrine orm:schema-tool:update --dump-sql ALTER TABLE ArticleItem DROP FOREIGN KEY ArticleItem_ibfk_1; ALTER TABLE ArticleItem ADD FOREIGN KEY (articleGroupId) REFERENCES ArticleGroup(id) ON DELETE RESTRICT everything ok, do: $ doctrine orm:schema-tool:update Change RESTRICT to NO ACTION $ doctrine orm:schema-tool:update --dump-sql // no output!! So there is no way to update database schema from RESTRICT to NO ACTION and reverse!
Hide
Permalink
Benjamin Eberlei added a comment -

Hm you are right, however for MySQL NO ACTION is the same as RESTRICT as stated by http://dev.mysql.com/doc/refman/5.1/en/innodb-foreign-key-constraints.html

Show
Benjamin Eberlei added a comment - Hm you are right, however for MySQL NO ACTION is the same as RESTRICT as stated by http://dev.mysql.com/doc/refman/5.1/en/innodb-foreign-key-constraints.html
Benjamin Eberlei made changes -
Project Doctrine 2 - ORM [ 10032 ] Doctrine DBAL [ 10040 ]
Key DDC-743 DBAL-58
Issue Type Bug [ 1 ] Improvement [ 4 ]
Affects Version/s 2.0-BETA2 [ 10050 ]
Component/s Schema Managers [ 10057 ]
Component/s ORM [ 10012 ]
Benjamin Eberlei made changes -
Workflow jira [ 11754 ] jira-feedback2 [ 17562 ]
Benjamin Eberlei made changes -
Workflow jira-feedback2 [ 17562 ] jira-feedback3 [ 19916 ]
This list may be incomplete, as errors occurred whilst retrieving source from linked applications:
  • Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=DBAL-58, expand=changesets[-21:-1].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

People

  • Assignee:
    Benjamin Eberlei
    Reporter:
    Jan Obrátil
Vote (1)
Watch (1)

Dates

  • Created:
    Updated: