Doctrine DBAL
  1. Doctrine DBAL
  2. DBAL-523

[GH-321] Changed property visibility to protected

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Security Level: All
    • Labels:
      None

      Description

      This issue is created automatically through a Github pull request on behalf of barnabywalters:

      Url: https://github.com/doctrine/dbal/pull/321

      Message:

      The main reason being to allow QueryBuilder to be subclassed ��� for example so that we can fix issues like problematic shallow cloning locally and use them without having to wait for a pull request to be merged.

        Activity

        Doctrine Bot created issue -
        Hide
        Doctrine Bot added a comment -

        A related Github Pull-Request [GH-321] was closed:
        https://github.com/doctrine/dbal/pull/321

        Show
        Doctrine Bot added a comment - A related Github Pull-Request [GH-321] was closed: https://github.com/doctrine/dbal/pull/321
        Hide
        Marco Pivetta added a comment -

        Enforces BC on the internals of the QueryBuilder, which is a no-go given the complexity of the QueryBuilder itself

        Show
        Marco Pivetta added a comment - Enforces BC on the internals of the QueryBuilder, which is a no-go given the complexity of the QueryBuilder itself
        Marco Pivetta made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Benjamin Eberlei [ beberlei ] Marco Pivetta [ ocramius ]
        Resolution Won't Fix [ 2 ]

        This list may be incomplete, as errors occurred whilst retrieving source from linked applications:

        • Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=DBAL-523, expand=changesets[0:20].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

          People

          • Assignee:
            Marco Pivetta
            Reporter:
            Doctrine Bot
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: