Doctrine DBAL
  1. Doctrine DBAL
  2. DBAL-498

[GH-306] [DBAL-497] Fixed SQL Server platform replacing 'FROM' in column names during limit

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.4
    • Component/s: None
    • Security Level: All
    • Labels:
      None

      Description

      This issue is created automatically through a Github pull request on behalf of shaneneuerburg:

      Url: https://github.com/doctrine/dbal/pull/306

      Message:

      The regex used to replace the FROM clause was in a "starts with" form, which also matched column names that start with the word "FROM". This resulted in column names being replaced with the logic used for limiting, breaking the query once pagination is used. I added a whitespace requirement after "FROM' in the regex as well as a trailing whitespace in the replacement.

        Activity

        Doctrine Bot created issue -
        Hide
        Doctrine Bot added a comment -

        A related Github Pull-Request [GH-306] was closed:
        https://github.com/doctrine/dbal/pull/306

        Show
        Doctrine Bot added a comment - A related Github Pull-Request [GH-306] was closed: https://github.com/doctrine/dbal/pull/306
        Hide
        Marco Pivetta added a comment -

        merged

        Show
        Marco Pivetta added a comment - merged
        Marco Pivetta made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Benjamin Eberlei [ beberlei ] Guilherme Blanco [ guilhermeblanco ]
        Resolution Fixed [ 1 ]
        Benjamin Eberlei made changes -
        Fix Version/s 2.4 [ 10320 ]
        Hide
        Doctrine Bot added a comment -

        A related Github Pull-Request [GH-306] was closed:
        https://github.com/doctrine/common/pull/306

        Show
        Doctrine Bot added a comment - A related Github Pull-Request [GH-306] was closed: https://github.com/doctrine/common/pull/306

        This list may be incomplete, as errors occurred whilst retrieving source from linked applications:

        • Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=DBAL-498, expand=changesets[0:20].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

          People

          • Assignee:
            Guilherme Blanco
            Reporter:
            Doctrine Bot
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: