Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.4
    • Component/s: None
    • Security Level: All
    • Labels:
      None

      Description

      This issue is created automatically through a Github pull request on behalf of deeky666:

      Url: https://github.com/doctrine/dbal/pull/295

      Message:

      The functional <code>ModifyLimitQueryTest</code> makes false expectations about the query results. <code>LIMIT</code> queries without <code>ORDER BY</code> clause return non-deterministic results, therefore the test cannot make any expectations about which values are returned and in which order. You can only expect a certain number of results.
      The test might still work on platforms like mysql when you assume results to be in an ascending order, because the database might put the results of a non-deterministic query in an ascending order by default. Still this is not reliable and not all vendors do that.
      This PR changes the tests to have an ordered, deterministic results by default to have more reliable expectations. Also one test about a non-deterministic query was added, which just asserts the number of results returned.

        Activity

        Hide
        Doctrine Bot added a comment -

        A related Github Pull-Request [GH-295] was closed:
        https://github.com/doctrine/common/pull/295

        Show
        Doctrine Bot added a comment - A related Github Pull-Request [GH-295] was closed: https://github.com/doctrine/common/pull/295
        Hide
        Benjamin Eberlei added a comment -

        A related Github Pull-Request [GH-295] was closed
        https://github.com/doctrine/dbal/pull/295

        Show
        Benjamin Eberlei added a comment - A related Github Pull-Request [GH-295] was closed https://github.com/doctrine/dbal/pull/295

          People

          • Assignee:
            Benjamin Eberlei
            Reporter:
            Benjamin Eberlei
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: