Doctrine DBAL
  1. Doctrine DBAL
  2. DBAL-470

[GH-291] Optimize abstract platform

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Security Level: All
    • Labels:
      None

      Description

      This issue is created automatically through a Github pull request on behalf of deeky666:

      Url: https://github.com/doctrine/dbal/pull/291

      Message:

      This PR optimizes the <code>AbstractPlatform</code> class in the following ways:

      • Add dedicated use statemtent for each class import
      • Add missing class imports
      • Add missing phpDoc blocks for methods
      • Fix existing phpDocs (parameters, return types, @throws tags, FQDN types, indentation etc.)
      • "Normalize" phpDocs (consistent verbs for what a method does, reuse of certain phrases for similar method types etc.)
      • Fix CS
      • Improve certain code portions

      I hope this is a welcomed improvement. It reads much better now and feels somewhat cleaner to me.

        Activity

        Benjamin Eberlei created issue -
        Hide
        Doctrine Bot added a comment -

        A related Github Pull-Request [GH-291] was closed:
        https://github.com/doctrine/common/pull/291

        Show
        Doctrine Bot added a comment - A related Github Pull-Request [GH-291] was closed: https://github.com/doctrine/common/pull/291
        Hide
        Fabio B. Silva added a comment -

        Closed ... See : https://github.com/doctrine/common/pull/291 for more details..

        Show
        Fabio B. Silva added a comment - Closed ... See : https://github.com/doctrine/common/pull/291 for more details..
        Fabio B. Silva made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 2.5 [ 10523 ]
        Resolution Fixed [ 1 ]
        Hide
        Steve Müller added a comment -

        @Fabio: Are you sure your comment is related to this issue? Looks like the PR you referenced is from Common repository but this ticket is related to DBAL...

        Show
        Steve Müller added a comment - @Fabio: Are you sure your comment is related to this issue? Looks like the PR you referenced is from Common repository but this ticket is related to DBAL...
        Hide
        Doctrine Bot added a comment -

        A related Github Pull-Request [GH-291] was closed:
        https://github.com/doctrine/dbal/pull/291

        Show
        Doctrine Bot added a comment - A related Github Pull-Request [GH-291] was closed: https://github.com/doctrine/dbal/pull/291
        Benjamin Eberlei made changes -
        Fix Version/s 2.5 [ 10523 ]

        This list may be incomplete, as errors occurred whilst retrieving source from linked applications:

        • Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=DBAL-470, expand=changesets[0:20].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

          People

          • Assignee:
            Benjamin Eberlei
            Reporter:
            Benjamin Eberlei
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: