Doctrine DBAL
  1. Doctrine DBAL
  2. DBAL-465

[GH-286] Fix data not being cached in ResultCache

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Invalid
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Security Level: All
    • Labels:
      None

      Description

      This issue is created automatically through a Github pull request on behalf of Alan01252:

      Url: https://github.com/doctrine/dbal/pull/286

      Message:

      The ResultCacheStatement has a small logic error, it tested for emptied
      being true when it should have tested for emptied being false. The
      comments also statement that the function returns a boolean, however the
      function didn't return a boolean.

      This is my first time committing to a larger open source project like dbal. Very worried I'll of done something wrong, please go easy / teach me.

        Activity

        Hide
        Benjamin Eberlei added a comment -

        A related Github Pull-Request [GH-286] was closed
        https://github.com/doctrine/dbal/pull/286

        Show
        Benjamin Eberlei added a comment - A related Github Pull-Request [GH-286] was closed https://github.com/doctrine/dbal/pull/286
        Hide
        Benjamin Eberlei added a comment -

        A related Github Pull-Request [GH-286] was reopened
        https://github.com/doctrine/dbal/pull/286

        Show
        Benjamin Eberlei added a comment - A related Github Pull-Request [GH-286] was reopened https://github.com/doctrine/dbal/pull/286
        Hide
        Benjamin Eberlei added a comment -

        A related Github Pull-Request [GH-286] was closed
        https://github.com/doctrine/dbal/pull/286

        Show
        Benjamin Eberlei added a comment - A related Github Pull-Request [GH-286] was closed https://github.com/doctrine/dbal/pull/286

          People

          • Assignee:
            Benjamin Eberlei
            Reporter:
            Benjamin Eberlei
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: