Doctrine DBAL

Logger should specify connection used in a master/slave situation

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Invalid
  • Affects Version/s: 2.3.2
  • Fix Version/s: 2.3.3
  • Component/s: None
  • Security Level: All
  • Labels:
    None

Description

Suppose there is a master connection with four slaves specified. Connections are being handled by the Doctrine\DBAL\Connections\MasterSlaveConnection class. Under the current implementation, all queries are logged under the "master" connection, even queries that are routed to the slaves by the Doctrine\DBAL\Connections\MasterSlaveConnection class.

Since slave connections are separate, distinct connections, queries should be logged appropriately under their respective connections.

Activity

Hide
Permalink
Benjamin Eberlei added a comment -

Two reasons why this is not feasible:

1. We actually don't ship loggers on our own, so if you want you can implement this yourself. We wouldn't have a way to "add" this, we only provide the interface.

2. However the logger does not have access to the connection to find out which slave or master its currently using, you can create a logger that has a "setConnection($conn)" method and call this during bootstrapping the logger+connection.

Show
Benjamin Eberlei added a comment - Two reasons why this is not feasible: 1. We actually don't ship loggers on our own, so if you want you can implement this yourself. We wouldn't have a way to "add" this, we only provide the interface. 2. However the logger does not have access to the connection to find out which slave or master its currently using, you can create a logger that has a "setConnection($conn)" method and call this during bootstrapping the logger+connection.

People

  • Assignee:
    Benjamin Eberlei
    Reporter:
    Jarrod Nettles
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: