Doctrine DBAL

missing column type "float"

Details

  • Type: New Feature New Feature
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.0.0-RC1-RC3
  • Component/s: None
  • Labels:
    None

Description

The former supported column type "float" is not defined in Doctrine\DBAL\Types\Type.

I noticed that floats are mapped like numerics/decimals within mysq right nowl:

protected function _getPortableTableColumnDefinition($tableColumn)
    {
       ...
        // Map db type to Doctrine mapping type
        switch ($dbType) {
            ...
            case 'float':
            case 'double':
            case 'real':
            case 'numeric':
                $type = 'decimal';
                break;

I suggest to map them to a "true" float and double as available in mysql, since they use less storage space compared to numerics with fixed decimals in certain cirtumstances (-> performance issue). http://dev.mysql.com/doc/refman/5.0/en/storage-requirements.html

Activity

Ascending order - Click to sort in descending order
Christian Ehmig made changes -
Field Original Value New Value
Description The former supported column type "float" is not defined in Doctrine\DBAL\Types\Type.

I noticed that floats should be mapped like numerics/decimals within mysql:

{code}
protected function _getPortableTableColumnDefinition($tableColumn)
    {
       ...
        // Map db type to Doctrine mapping type
        switch ($dbType) {
            ...
            case 'float':
            case 'double':
            case 'real':
            case 'numeric':
                $type = 'decimal';
                break;
{code}

I suggest to map them to a "true" float and double as available in mysql, since they use less storage space compared to numerics with fixed decimals in certain cirtumstances (-> performance issue). http://dev.mysql.com/doc/refman/5.0/en/storage-requirements.html

 The former supported column type "float" is not defined in Doctrine\DBAL\Types\Type.

I noticed that floats are mapped like numerics/decimals within mysq right nowl:

{code}
protected function _getPortableTableColumnDefinition($tableColumn)
    {
       ...
        // Map db type to Doctrine mapping type
        switch ($dbType) {
            ...
            case 'float':
            case 'double':
            case 'real':
            case 'numeric':
                $type = 'decimal';
                break;
{code}

I suggest to map them to a "true" float and double as available in mysql, since they use less storage space compared to numerics with fixed decimals in certain cirtumstances (-> performance issue). http://dev.mysql.com/doc/refman/5.0/en/storage-requirements.html
Hide
Permalink
Guilherme Blanco added a comment -

This issue was already fixed before. Check out line 192 in MySqlSchemaManager.php

Show
Guilherme Blanco added a comment - This issue was already fixed before. Check out line 192 in MySqlSchemaManager.php
Guilherme Blanco made changes -
Status Open [ 1 ] Closed [ 6 ]
Resolution Fixed [ 1 ]
Roman S. Borschel made changes -
Component/s ORM [ 10012 ]
Component/s DBAL [ 10011 ]
Hide
Permalink
Benjamin Eberlei added a comment -

This issue is regarding the support for an additional Type "Float" vs the "Decimal" which is a precise type.

A quick google over all the vendors shows that they all support floating point numbers.

Show
Benjamin Eberlei added a comment - This issue is regarding the support for an additional Type "Float" vs the "Decimal" which is a precise type. A quick google over all the vendors shows that they all support floating point numbers.
Benjamin Eberlei made changes -
Resolution Fixed [ 1 ]
Status Closed [ 6 ] Reopened [ 4 ]
Roman S. Borschel made changes -
Project Doctrine 2 - ORM [ 10032 ] Doctrine DBAL [ 10040 ]
Key DDC-67 DBAL-41
Issue Type Bug [ 1 ] New Feature [ 2 ]
Affects Version/s 2.0-ALPHA2 [ 10028 ]
Component/s ORM [ 10012 ]
Roman S. Borschel made changes -
Assignee Roman S. Borschel [ romanb ] Benjamin Eberlei [ beberlei ]
Hide
Permalink
Steffen Vogel added a comment -

Push...
Tut sich hier noch was? Oder soll ich mir den Typ lieber selbst implementieren? Bringt es was wenn ich ihn euch dann per Pull-Request ins github mergen kann?

gruß Steffen

Show
Steffen Vogel added a comment - Push... Tut sich hier noch was? Oder soll ich mir den Typ lieber selbst implementieren? Bringt es was wenn ich ihn euch dann per Pull-Request ins github mergen kann? gruß Steffen
Hide
Permalink
Benjamin Eberlei added a comment -

All currently supported databases have a "DOUBLE PRECISION" type or use that as an alias for their float. Supporting this will be super-easy

Show
Benjamin Eberlei added a comment - All currently supported databases have a "DOUBLE PRECISION" type or use that as an alias for their float. Supporting this will be super-easy
Hide
Permalink
Benjamin Eberlei added a comment -

Implemented and to be released with the RC1

Show
Benjamin Eberlei added a comment - Implemented and to be released with the RC1
Benjamin Eberlei made changes -
Status Reopened [ 4 ] Resolved [ 5 ]
Fix Version/s 2.0.0-RC1 [ 10094 ]
Resolution Fixed [ 1 ]
Benjamin Eberlei made changes -
Workflow jira [ 10250 ] jira-feedback2 [ 17620 ]
Benjamin Eberlei made changes -
Workflow jira-feedback2 [ 17620 ] jira-feedback3 [ 19975 ]
This list may be incomplete, as errors occurred whilst retrieving source from linked applications:
  • Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=DBAL-41, expand=changesets[-21:-1].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

People

  • Assignee:
    Benjamin Eberlei
    Reporter:
    Christian Ehmig
Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: