Doctrine DBAL
  1. Doctrine DBAL
  2. DBAL-416

[GH-249] Fixed doModifyLimitQuery for SQLServerPlatform

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.3.3
    • Component/s: None
    • Security Level: All
    • Labels:
      None

      Description

      This issue is created automatically through a Github pull request on behalf of norzechowicz:

      Url: https://github.com/doctrine/dbal/pull/249

      Message:

      It seems that there is a problem in SQLServerPlatform ``doModifyLimitQuery`` method.
      I can't use Doctrine ORM Paginator because of wrong position of ``DISTINCT`` statement in final limit subquery, here is the exception message I'm getting.
      ``SQLSTATE[42000]: [Microsoft][SQL Server Native Client 10.0][SQL Server]Incorrect syntax near the keyword 'DISTINCT'.``

      My proposition is to change ``doModifyLimitQuery`` result from:

      ``SELECT * FROM (SELECT ROW_NUMBER() OVER (ORDER BY username DESC) AS doctrine_rownum, * FROM user) ...``

      into:

      ``SELECT * FROM (SELECT *, ROW_NUMBER() OVER (ORDER BY username DESC) AS doctrine_rownum FROM user) ...``

        Activity

          People

          • Assignee:
            Benjamin Eberlei
            Reporter:
            Benjamin Eberlei
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: