Uploaded image for project: 'Doctrine DBAL'
  1. Doctrine DBAL
  2. DBAL-39

SQL Logger should log the last failed query

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-BETA3
    • Fix Version/s: 2.0.0-BETA4
    • Component/s: None
    • Labels:
      None

      Description

      The SQL Logger is only called after a query has been executed (this was changed to allow profiling of the queries). This makes it difficult to determine which query has failed.

      The commit that changed the functionality is at: http://github.com/doctrine/dbal/commit/fe0f0e4b8c6c5308cab3d683c552f61317de7067

      It seems that the logger interface needs to be changed to two functions, a pre-query function and a post-query function. Profiling should be handled by the logger if it chooses and not by the connection class.

        Activity

        Hide
        beberlei Benjamin Eberlei added a comment -

        After lots of thinking i changed the Logger again to have a startQuery() and a stopQuery() method now.

        Show
        beberlei Benjamin Eberlei added a comment - After lots of thinking i changed the Logger again to have a startQuery() and a stopQuery() method now.

          People

          • Assignee:
            beberlei Benjamin Eberlei
            Reporter:
            mridgway Michael Ridgway
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: