Doctrine DBAL
  1. Doctrine DBAL
  2. DBAL-359

[GH-211] Fix dropping foreign key multiple times with test

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Invalid
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Security Level: All
    • Labels:
      None

      Description

      This issue is created automatically through a Github pull request on behalf of sdepablos:

      Url: https://github.com/doctrine/dbal/pull/211

      Message:

      In some cases the Comparator class returns multiple drops for the same foreign key.
      Specifically, in case you have two tables, A & B, with A having a foreign key FK
      referencing B, if you drop table B, the resulting diff shows this FK twice,
      once on the diff->orphanedForeignKeys array as we're deleting B, and another on
      the diff->changedTables array as table A is also being modified. As a result of this you
      get the DROP FOREIGN KEY instruction twice in the final SQL.

      I'm not really sure if this change should be done in the Comparator clas or if it's better to
      receive the full diff, even with duplicated drops for FK and later, when generating the final
      SQL, drop the unnecessary ones

        Activity

          People

          • Assignee:
            Benjamin Eberlei
            Reporter:
            Benjamin Eberlei
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: