This issue should be removed. Wrong merge on github.

Ascending order - Click to sort in descending order

Field	Original Value	New Value
Summary	[GH-210] Fix dropping foreign key multiple times with test	This issue should be removed. Wrong merge on github.
Description	This issue is created automatically through a Github pull request on behalf of sdepablos: Url: https://github.com/doctrine/dbal/pull/210 Message: In some cases the Comparator class returns multiple drops for the same foreign key. Specifically, in case you have two tables, A & B, with A having a foreign key FK referencing B, if you drop table B, the resulting diff shows this FK twice, once on the diff->orphanedForeignKeys array as we're deleting B, and another on the diff->changedTables array as table A is also being modified. As a result of this you get the DROP FOREIGN KEY instruction twice in the final SQL. I'm not really sure if this change should be done in Comparator or if it's better to receive the full diff, even with duplicated drops for FK and later, when generating the final SQL, dropping the unnecesary ones	This issue should be removed. Wrong merge on github.
Priority	Major [ 3 ]	Trivial [ 5 ]

Marco Pivetta made changes - 23/Jan/13 11:01 PM

Vote (0)

Watch (1)