Doctrine DBAL
  1. Doctrine DBAL
  2. DBAL-358

This issue should be removed. Wrong merge on github.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Invalid
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Security Level: All
    • Labels:
      None

      Description

      This issue should be removed. Wrong merge on github.

        Activity

        Benjamin Eberlei created issue -
        Hide
        Benjamin Eberlei added a comment -

        A related Github Pull-Request [GH-210] was closed
        https://github.com/doctrine/dbal/pull/210

        Show
        Benjamin Eberlei added a comment - A related Github Pull-Request [GH-210] was closed https://github.com/doctrine/dbal/pull/210
        Sergi de Pablos made changes -
        Field Original Value New Value
        Summary [GH-210] Fix dropping foreign key multiple times with test This issue should be removed. Wrong merge on github.
        Description This issue is created automatically through a Github pull request on behalf of sdepablos:

          Url: https://github.com/doctrine/dbal/pull/210

        Message:

        In some cases the Comparator class returns multiple drops for the same foreign key.
        Specifically, in case you have two tables, A & B, with A having a foreign key FK
        referencing B, if you drop table B, the resulting diff shows this FK twice,
        once on the diff->orphanedForeignKeys array as we're deleting B, and another on
        the diff->changedTables array as table A is also being modified. As a result of this you
        get the DROP FOREIGN KEY instruction twice in the final SQL.

        I'm not really sure if this change should be done in Comparator or if it's better to receive the full diff, even with duplicated drops for FK and later, when generating the final SQL, dropping the unnecesary ones
        This issue should be removed. Wrong merge on github.
        Priority Major [ 3 ] Trivial [ 5 ]
        Marco Pivetta made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Assignee Benjamin Eberlei [ beberlei ] Marco Pivetta [ ocramius ]
        Resolution Invalid [ 6 ]
        Hide
        Doctrine Bot added a comment -

        A related Github Pull-Request [GH-210] was closed:
        https://github.com/doctrine/common/pull/210

        Show
        Doctrine Bot added a comment - A related Github Pull-Request [GH-210] was closed: https://github.com/doctrine/common/pull/210

        This list may be incomplete, as errors occurred whilst retrieving source from linked applications:

        • Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=DBAL-358, expand=changesets[0:20].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

          People

          • Assignee:
            Marco Pivetta
            Reporter:
            Benjamin Eberlei
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: