Doctrine DBAL

allow SQL QueryBuilder to do INSERTS

Details

  • Type: New Feature New Feature
  • Status: Reopened Reopened
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 2.3
  • Fix Version/s: None
  • Component/s: None
  • Security Level: All
  • Labels:
    None

Description

With

$db = \Doctrine\DBAL\DriverManager::getConnection($connectionParams, $config);
$qb = $db->createQueryBuilder();

this QueryBuilder I'm able to do SELECT, UPDATE and DELETE. However, INSERT is not possible. Are there any good reasons for this?

Attached you find a patch that until now works fine for me. I don't know, however, if there are any side effects.

Activity

Descending order - Click to sort in ascending order
Hide
Permalink
Tim Mundt added a comment -

Here's the PR: https://github.com/doctrine/dbal/pull/184

Show
Tim Mundt added a comment - Here's the PR: https://github.com/doctrine/dbal/pull/184
Hide
Permalink
Marco Pivetta added a comment -

You'd need to add tests in https://github.com/doctrine/dbal/blob/master/tests/Doctrine/Tests/DBAL/Query/QueryBuilderTest.php (to be included in your patch or in a github pull request)
A Github PR is also the fastest way to get your code reviewed since not everyone visits the issue tracker.

Show
Marco Pivetta added a comment - You'd need to add tests in https://github.com/doctrine/dbal/blob/master/tests/Doctrine/Tests/DBAL/Query/QueryBuilderTest.php (to be included in your patch or in a github pull request) A Github PR is also the fastest way to get your code reviewed since not everyone visits the issue tracker.
Hide
Permalink
Tim Mundt added a comment -

Glad to hear there seems to be no fundamental problem with this. Can I somehow help this patch go into the code? I'm not familiar with the tests here. If you give me some pointer, maybe I can come up with something useful. On the other hand, it could be a good idea for some more involved people to have a look at this before.

Show
Tim Mundt added a comment - Glad to hear there seems to be no fundamental problem with this. Can I somehow help this patch go into the code? I'm not familiar with the tests here. If you give me some pointer, maybe I can come up with something useful. On the other hand, it could be a good idea for some more involved people to have a look at this before.
Hide
Permalink
Marco Pivetta added a comment -

This is actually valid (even the patch, though it needs to adds tests)

Show
Marco Pivetta added a comment - This is actually valid (even the patch, though it needs to adds tests)
Hide
Permalink
Marco Pivetta added a comment -

Tim Mundt Ouch, no, it was my fault, sorry.
I confused the project related to the issue.

Show
Marco Pivetta added a comment - Tim Mundt Ouch, no, it was my fault, sorry. I confused the project related to the issue.
Hide
Permalink
Tim Mundt added a comment -

see previous comment, I'd appreciate some clarification

Show
Tim Mundt added a comment - see previous comment, I'd appreciate some clarification
Hide
Permalink
Tim Mundt added a comment -

Well, that was quick and not helpful. I have read about the QueryBuilder in the ORM package. For some reason with persistence (that other libraries don't have), insert cannot be supported. However, I'm talking about DBAL here. What good reason is there not to support INSERT??

Show
Tim Mundt added a comment - Well, that was quick and not helpful. I have read about the QueryBuilder in the ORM package. For some reason with persistence (that other libraries don't have), insert cannot be supported. However, I'm talking about DBAL here. What good reason is there not to support INSERT??
Hide
Permalink
Marco Pivetta added a comment -

Insert is not supported by DQL

Show
Marco Pivetta added a comment - Insert is not supported by DQL

People

  • Assignee:
    Benjamin Eberlei
    Reporter:
    Tim Mundt
Vote (0)
Watch (2)

Dates

  • Created:
    Updated: